Skip to contentSkip to conversation

spi: kirkwood: add orion-spi compatible string

PATCH New Chris Packham 4 participants 4 messages May 7, 2018 – Aug 1, 2018 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: kirkwood: add orion-spi compatible string

This matches the compatible string used by the Linux kernel. This will allow u-boot to use the same device tree files.

---
This applies on top of Jagan's series
http://patchwork.ozlabs.org/project/uboot/list/?series=33927

 drivers/spi/kirkwood_spi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/spi/kirkwood_spi.c +8 -0
index 036fc36b8329..6a5ab8a1cba4 100644
@@ -226,6 +226,10 @@ static int mvebu_spi_ofdata_to_platdata(struct udevice *bus)
 	return 0;
 }
 
+static const struct mvebu_spi_dev orion_spi_dev_data = {
+	.is_errata_50mhz_ac = false,
+};
+
 static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
 	.is_errata_50mhz_ac = false,
 };
@@ -239,6 +243,10 @@ static const struct mvebu_spi_dev armada_380_spi_dev_data = {
 };
 
 static const struct udevice_id mvebu_spi_ids[] = {
+	{
+		.compatible = "marvell,orion-spi",
+		.data = (ulong)&orion_spi_dev_data
+	},
 	{
 		.compatible = "marvell,armada-375-spi",
 		.data = (ulong)&armada_375_spi_dev_data
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 spi: kirkwood: add orion-spi compatible string

Quoted 27 lines · Chris Packham

This matches the compatible string used by the Linux kernel. This will allow u-boot to use the same device tree files.

---
This applies on top of Jagan's series
http://patchwork.ozlabs.org/project/uboot/list/?series=33927

 drivers/spi/kirkwood_spi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/spi/kirkwood_spi.c +4 -0
index 036fc36b8329..6a5ab8a1cba4 100644
@@ -226,6 +226,10 @@ static int mvebu_spi_ofdata_to_platdata(struct udevice *bus)
        return 0;
 }
 
+static const struct mvebu_spi_dev orion_spi_dev_data = {
+       .is_errata_50mhz_ac = false,
+};
+
 static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
        .is_errata_50mhz_ac = false,
 };

drivers/spi/kirkwood_spi.c static const struct mvebu_spi_dev armada_380_spi_dev_data = { · line 248

Quoted 6 lines
drivers/spi/kirkwood_spi.c +3 -0
@@ -239,6 +243,10 @@ static const struct mvebu_spi_dev armada_380_spi_dev_data = {
 };
 
 static const struct udevice_id mvebu_spi_ids[] = {
+       {
+               .compatible = "marvell,orion-spi",
+               .data = (ulong)&orion_spi_dev_data
#2 lore raw

PATCH 1/1 spi: kirkwood: add orion-spi compatible string

Quoted 30 lines · Jagan Teki
Quoted 29 lines · Chris Packham

This matches the compatible string used by the Linux kernel. This will allow u-boot to use the same device tree files.

---
This applies on top of Jagan's series
http://patchwork.ozlabs.org/project/uboot/list/?series=33927

 drivers/spi/kirkwood_spi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/spi/kirkwood_spi.c +4 -0
index 036fc36b8329..6a5ab8a1cba4 100644
@@ -226,6 +226,10 @@ static int mvebu_spi_ofdata_to_platdata(struct udevice *bus)
        return 0;
 }
 
+static const struct mvebu_spi_dev orion_spi_dev_data = {
+       .is_errata_50mhz_ac = false,
+};
+
 static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
        .is_errata_50mhz_ac = false,
 };
@@ -239,6 +243,10 @@ static const struct mvebu_spi_dev armada_380_spi_dev_data = {
 };
 
Quoted 6 lines

drivers/spi/kirkwood_spi.c static const struct mvebu_spi_dev armada_380_spi_dev_data = { · line 248

Quoted 4 lines
drivers/spi/kirkwood_spi.c +3 -0
 static const struct udevice_id mvebu_spi_ids[] = {
+       {
+               .compatible = "marvell,orion-spi",
+               .data = (ulong)&orion_spi_dev_data

Applied to u-boot-spi/master

#3 lore raw

PATCH 1/1 spi: kirkwood: add orion-spi compatible string

In reply to Chris Packham

Am 2018-05-08 00:54, schrieb Chris Packham:

Quoted 2 lines

This matches the compatible string used by the Linux kernel. This will allow u-boot to use the same device tree files.

This patch is still missing to make SPI on kirkwoods work. Is there anything missing which prevents it from being applied?

-michael

Quoted 37 lines

---
This applies on top of Jagan's series
http://patchwork.ozlabs.org/project/uboot/list/?series=33927

 drivers/spi/kirkwood_spi.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/spi/kirkwood_spi.c +4 -0
index 036fc36b8329..6a5ab8a1cba4 100644
@@ -226,6 +226,10 @@ static int mvebu_spi_ofdata_to_platdata(struct
 udevice *bus)
 	return 0;
 }
 
+static const struct mvebu_spi_dev orion_spi_dev_data = {
+	.is_errata_50mhz_ac = false,
+};
+
 static const struct mvebu_spi_dev armada_xp_spi_dev_data = {
 	.is_errata_50mhz_ac = false,

};

drivers/spi/kirkwood_spi.c +4 -0
@@ -239,6 +243,10 @@ static const struct mvebu_spi_dev
 armada_380_spi_dev_data = {
 };
 
 static const struct udevice_id mvebu_spi_ids[] = {
+	{
+		.compatible = "marvell,orion-spi",
+		.data = (ulong)&orion_spi_dev_data
+	},
 	{
 		.compatible = "marvell,armada-375-spi",

.data = (ulong)&armada_375_spi_dev_data