Skip to contentSkip to conversation

Use a more specific regex to detect fuego_release_test failures

PATCH In review Guilherme Campos Camargo 2 participants 2 messages May 8, 2018 – May 9, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use a more specific regex to detect fuego_release_test failures

Detect any failure by using log_compare in inverse mode (n). Also use a more specific regex (including the prefix 'test_run:REPORT').

---
 engine/tests/Functional.fuego_release_test/fuego_test.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
engine/tests/Functional.fuego_release_test/fuego_test.sh +1 -2
index 242fa70..5fe8545 100755
@@ -25,6 +25,5 @@ function test_run {
 }
 
 function test_processing {
-    log_compare "$TESTDIR" "1" "ok" "p"
-    log_compare "$TESTDIR" "0" "not ok" "n"
+    log_compare "$TESTDIR" "0" "test_run:REPORT: not ok" "n"
 }
Signature · 1 line
2.17.0
#1 lore raw

Applied and pushed.

To answer your earlier question - let's try it with just the 'n'-flavored log_compare, and see what happens. I tend to agree that if we expect all tests to complete, and the tests are being actively added to, it reduces maintenance to just use the "'not ok' 0" test.

Thanks!
-- Tim

Quoted 37 lines

-----Original Message-----
From: [email protected] [mailto:fuego- [email protected]] On Behalf Of Guilherme Campos Camargo
Sent: Monday, May 07, 2018 5:09 PM
To: [email protected]
Subject: [Fuego] [PATCH] Use a more specific regex to detect fuego_release_test failures

Detect any failure by using log_compare in inverse mode (n). Also use a more specific regex (including the prefix 'test_run:REPORT').

---
 engine/tests/Functional.fuego_release_test/fuego_test.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
engine/tests/Functional.fuego_release_test/fuego_test.sh +1 -3
index 242fa70..5fe8545 100755
@@ -25,6 +25,5 @@ function test_run {
 }
 
 function test_processing {
-    log_compare "$TESTDIR" "1" "ok" "p"
-    log_compare "$TESTDIR" "0" "not ok" "n"
+    log_compare "$TESTDIR" "0" "test_run:REPORT: not ok" "n"
 }
--

2.17.0

_______________________________________________
Fuego mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/fuego