Skip to contentSkip to conversation

perf: test 60 fails on s390 inline missing on s390

PATCH Applied Thomas Richter 3 participants 3 messages May 3, 2018 – May 15, 2018 perf events

lore
Share & tools
lore

Thomas Richter

author
#0 lore raw

PATCH 1/1 perf: test 60 fails on s390 inline missing on s390

perf test 60: probe libc's inet_pton & backtrace it with ping fails on 4.17.0rc3. It turned out that function __inet_pton is reported as inline:

[root@s8360047 perf]# ./perf script -i /tmp/perf.data.111 ping 12457 [000] 1584.478959: probe_libc:inet_pton: (3ffb5a347e8)

                  1347e8 __inet_pton (inlined)
                   f19d7 gaih_inet.constprop.5 (/usr/lib64/libc-2.24.so)
                   f4c3f __GI_getaddrinfo (inlined)
                    410b main (/usr/bin/ping)

Allow __inet_pton listed as inline.

Signed-off-by Thomas Richter <[email protected]>
---
 tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/record+probe_libc_inet_pton.sh +1 -1
index 016882d..ee86473 100755
@@ -16,7 +16,7 @@ nm -g $libc 2>/dev/null | fgrep -q inet_pton || exit 254
 trace_libc_inet_pton_backtrace() {
 	idx=0
 	expected[0]="ping[][0-9 \.:]+probe_libc:inet_pton: \([[:xdigit:]]+\)"
-	expected[1]=".*inet_pton[[:space:]]\($libc\)$"
+	expected[1]=".*inet_pton[[:space:]]\($libc|inlined\)$"
 	case "$(uname -m)" in
 	s390x)
 		eventattr='call-graph=dwarf,max-stack=4'
Signature · 1 line
2.9.3
maintainer Applied
#1 lore raw

Em Thu, May 03, 2018 at 08:58:37AM +0200, Thomas Richter escreveu:

Quoted 4 lines

perf test 60: probe libc's inet_pton & backtrace it with ping fails on 4.17.0rc3. It turned out that function __inet_pton is reported as inline:

Quoted 8 lines

[root@s8360047 perf]# ./perf script -i /tmp/perf.data.111 ping 12457 [000] 1584.478959: probe_libc:inet_pton: (3ffb5a347e8)

                  1347e8 __inet_pton (inlined)
                   f19d7 gaih_inet.constprop.5 (/usr/lib64/libc-2.24.so)
                   f4c3f __GI_getaddrinfo (inlined)
                    410b main (/usr/bin/ping)

Allow __inet_pton listed as inline.

Thanks, applied,

- Arnaldo

merge bot
#2 lore raw

[tip:perf/urgent] perf test: "probe libc's inet_pton" fails on s390 due to missing inline

In reply to Thomas Richter
perf test: "probe libc's inet_pton" fails on s390 due to missing inline
Commit-ID:  f8207b987fdc3768257704579bf29a717b4ea520
Gitweb:     https://git.kernel.org/tip/f8207b987fdc3768257704579bf29a717b4ea520
Author:     Thomas Richter <[email protected]>
AuthorDate: Thu, 3 May 2018 08:58:37 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 10 May 2018 15:19:30 -0300

perf test: "probe libc's inet_pton" fails on s390 due to missing inline

perf test "probe libc's inet_pton & backtrace it with ping" fails on 4.17.0rc3 on s/390. It turned out that function __inet_pton is reported as inline:

[root@s8360047 perf]# ./perf script -i /tmp/perf.data.111 ping 12457 [000] 1584.478959: probe_libc:inet_pton: (3ffb5a347e8)

                    1347e8 __inet_pton (inlined)
                     f19d7 gaih_inet.constprop.5 (/usr/lib64/libc-2.24.so)
                     f4c3f __GI_getaddrinfo (inlined)
                      410b main (/usr/bin/ping)

Allow __inet_pton listed as inline.

Signed-off-by Thomas Richter <[email protected]>
Cc Heiko Carstens <[email protected]>
Cc Hendrik Brueckner <[email protected]>
Cc Martin Schwidefsky <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/shell/record+probe_libc_inet_pton.sh +1 -1
index 016882dbbc16..ee86473643be 100755
@@ -16,7 +16,7 @@ nm -g $libc 2>/dev/null | fgrep -q inet_pton || exit 254
 trace_libc_inet_pton_backtrace() {
 	idx=0
 	expected[0]="ping[][0-9 \.:]+probe_libc:inet_pton: \([[:xdigit:]]+\)"
-	expected[1]=".*inet_pton[[:space:]]\($libc\)$"
+	expected[1]=".*inet_pton[[:space:]]\($libc|inlined\)$"
 	case "$(uname -m)" in
 	s390x)
 		eventattr='call-graph=dwarf,max-stack=4'