arm64: dts: juno: fix OF graph endpoint node names

The ETF input should be connected to the funnel output, and the ETF output should be connected to the replicator input. The labels are wrong and these got swapped:

Warning (graph_endpoint): /soc/funnel at 821000/ports/port at 8/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 1/endpoint' is not bidirectional Warning (graph_endpoint): /soc/replicator at 824000/ports/port at 2/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 0/endpoint' is not bidirectional

Fixes 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")

Cc Ivan T. Ivanov <[email protected]>

Cc Mathieu Poirier <[email protected]>

Cc Andy Gross <[email protected]>

Cc David Brown <[email protected]>

Cc linux-arm-msm at vger.kernel.org

Signed-off-by Rob Herring <[email protected]>

---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Quoted 14 lines

The ETF input should be connected to the funnel output, and the ETF output should be connected to the replicator input. The labels are wrong and these got swapped:

Warning (graph_endpoint): /soc/funnel at 821000/ports/port at 8/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 1/endpoint' is not bidirectional Warning (graph_endpoint): /soc/replicator at 824000/ports/port at 2/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 0/endpoint' is not bidirectional

Fixes 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")

Cc Ivan T. Ivanov <[email protected]>

Cc Mathieu Poirier <[email protected]>

Cc Andy Gross <[email protected]>

Cc David Brown <[email protected]>

Cc linux-arm-msm at vger.kernel.org

Signed-off-by Rob Herring <[email protected]>

Quoted 3 lines

---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Ping. Still seeing warnings in -next for these.

Quoting Rob Herring (2018-05-23 23:29:29)

Quoted 19 lines · Rob Herring

Quoted 17 lines

The ETF input should be connected to the funnel output, and the ETF output should be connected to the replicator input. The labels are wrong and these got swapped:

Warning (graph_endpoint): /soc/funnel at 821000/ports/port at 8/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 1/endpoint' is not bidirectional Warning (graph_endpoint): /soc/replicator at 824000/ports/port at 2/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 0/endpoint' is not bidirectional

Fixes 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")

Cc Ivan T. Ivanov <[email protected]>

Cc Mathieu Poirier <[email protected]>

Cc Andy Gross <[email protected]>

Cc David Brown <[email protected]>

Cc linux-arm-msm at vger.kernel.org

Signed-off-by Rob Herring <[email protected]>

---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Quoted 2 lines

Ping. Still seeing warnings in -next for these.

Hi Rob,

I no longer have access to this hardware and documentation. I am sure that Mathieu and friends will take care for verification of this patch :-)

Regards,
Ivan

Quoted 6 lines

Hi Rob,

I no longer have access to this hardware and documentation. I am sure that Mathieu and friends will take care for verification of this patch :-)

The code triggers on the "slave-mode" property rather than the labels, so this patch has no effect on how a path is established. I've tested this on a 410c and things look good.

Reviewed-by Mathieu Poirier <[email protected]>

Tested-by Mathieu Poirier <[email protected]>

dtc now warns on incomplete OF graph endpoint connections:

arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm at 10006000/port/endpoint: graph connection to node '/soc/funnel at 10001000/ports/port at 2/endpoint' is not bidirectional

The cause is a typo in 'remote-endpoint'.

Cc Orson Zhai <[email protected]>

Cc Baolin Wang <[email protected]>

Cc Chunyan Zhang <[email protected]>

Signed-off-by Rob Herring <[email protected]>

---
 arch/arm64/boot/dts/sprd/sc9860.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm64/boot/dts/sprd/sc9860.dtsi +1 -2

index 5dbfb796d9f9..dcd03ffcda03 100644
@@ -326,7 +326,7 @@
                                        reg = <4>;
                                        soc_funnel_in_port1: endpoint {
                                                slave-mode;
-                                               remote-endpioint =
+                                               remote-endpoint =
                                                        <&stm_out_port>;
                                        };
                                };
--

2.17.0

Hi Rob,

Quoted 2 lines · Rob Herring

dtc now warns on incomplete OF graph endpoint connections:

Quoted 3 lines

arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm at 10006000/port/endpoint: graph connection to node '/soc/funnel at 10001000/ports/port at 2/endpoint' is not bidirectional

The cause is a typo in 'remote-endpoint'.

Thanks for fixing this and,

Acked-by Chunyan Zhang <[email protected]>

Quoted 7 lines · Chunyan Zhang

Hi Rob,

Quoted 4 lines · Rob Herring

dtc now warns on incomplete OF graph endpoint connections:

arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm at 10006000/port/endpoint: graph connection to node '/soc/funnel at 10001000/ports/port at 2/endpoint' is not bidirectional

Quoted 5 lines

Quoted 1 line

The cause is a typo in 'remote-endpoint'.

Thanks for fixing this and,

Acked-by Chunyan Zhang <[email protected]>

Is someone going to apply this? Still seeing warnings in linux-next.

Quoted 5 lines · Chunyan Zhang

Hi Rob,

Quoted 2 lines · Rob Herring

dtc now warns on incomplete OF graph endpoint connections:

Quoted 7 lines

Quoted 3 lines

arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm at 10006000/port/endpoint: graph connection to node '/soc/funnel at 10001000/ports/port at 2/endpoint' is not bidirectional

The cause is a typo in 'remote-endpoint'.

Thanks for fixing this and,

Acked-by Chunyan Zhang <[email protected]>

Is someone going to apply this? Still seeing warnings in linux-next.

Rob

Hi Arnd, Olof

Could you please take this patch through arm-soc git?

OF graph endpoint node names should be 'endpoint'. Fix the following warnings found by dtc:

Warning (graph_endpoint): /hdlcd at 7ff50000/port/hdlcd1-endpoint: graph endpont node nameshould be 'endpoint' Warning (graph_endpoint): /hdlcd at 7ff60000/port/hdlcd0-endpoint: graph endpont node nameshould be 'endpoint' Warning (graph_endpoint): /i2c at 7ffa0000/hdmi-transmitter at 70/port/tda998x-0-endpoint: graph endpont node name should be 'endpoint' Warning (graph_endpoint): /i2c at 7ffa0000/hdmi-transmitter at 71/port/tda998x-1-endpoint: graph endpont node name should be 'endpoint'

Cc Liviu Dudau <[email protected]>

Cc Sudeep Holla <[email protected]>

Cc Lorenzo Pieralisi <[email protected]>

Signed-off-by Rob Herring <[email protected]>

---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

arch/arm64/boot/dts/arm/juno-base.dtsi +4 -4

index eb749c50a736..b2fedaab3fcc 100644
@@ -677,7 +677,7 @@
 		clock-names = "pxlclk";
 
 		port {
-			hdlcd1_output: hdlcd1-endpoint {
+			hdlcd1_output: endpoint {
 				remote-endpoint = <&tda998x_1_input>;
 			};
 		};

@@ -692,7 +692,7 @@
 		clock-names = "pxlclk";
 
 		port {
-			hdlcd0_output: hdlcd0-endpoint {
+			hdlcd0_output: endpoint {
 				remote-endpoint = <&tda998x_0_input>;
 			};
 		};

@@ -720,7 +720,7 @@
 			compatible = "nxp,tda998x";
 			reg = <0x70>;
 			port {
-				tda998x_0_input: tda998x-0-endpoint {
+				tda998x_0_input: endpoint {
 					remote-endpoint = <&hdlcd0_output>;
 				};
 			};

@@ -730,7 +730,7 @@
 			compatible = "nxp,tda998x";
 			reg = <0x71>;
 			port {
-				tda998x_1_input: tda998x-1-endpoint {
+				tda998x_1_input: endpoint {
 					remote-endpoint = <&hdlcd1_output>;
 				};
 			};

Signature · 1 line

2.17.0

OF graph endpoint node names should be 'endpoint'. Fix the following warnings found by dtc:

Warning (graph_endpoint): /hdlcd at 7ff50000/port/hdlcd1-endpoint: graph endpont node nameshould be 'endpoint' Warning (graph_endpoint): /hdlcd at 7ff60000/port/hdlcd0-endpoint: graph endpont node nameshould be 'endpoint' Warning (graph_endpoint): /i2c at 7ffa0000/hdmi-transmitter at 70/port/tda998x-0-endpoint: graph endpont node name should be 'endpoint' Warning (graph_endpoint): /i2c at 7ffa0000/hdmi-transmitter at 71/port/tda998x-1-endpoint: graph endpont node name should be 'endpoint'

Cc Liviu Dudau <[email protected]>

Cc Sudeep Holla <[email protected]>

Cc Lorenzo Pieralisi <[email protected]>

Signed-off-by Rob Herring <[email protected]>