Skip to contentSkip to conversation

staging: sm750fb: add SPDX license identifier

PATCH In review Sumit Kumar 2 participants 4 messages May 8, 2018 – May 14, 2018

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Sumit Kumar

author
#0 lore raw

PATCH 1/1 staging: sm750fb: add SPDX license identifier

SPDX licencse identifier is missing in header file. Add a SPDX license identifier with correct format. Issue found by checkpatch.

Signed-off-by Sumit Kumar <[email protected]>
---
 drivers/staging/sm750fb/ddk750.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/sm750fb/ddk750.h +1 -0
index 7340103..482c1c6 100644
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  *         Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
  *
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 13 lines · Sumit Kumar

SPDX licencse identifier is missing in header file. Add a SPDX license identifier with correct format. Issue found by checkpatch.

Signed-off-by Sumit Kumar <[email protected]>
---
 drivers/staging/sm750fb/ddk750.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/sm750fb/ddk750.h +0 -0
index 7340103..482c1c6 100644

drivers/staging/sm750fb/ddk750.h line 1

Quoted 1 line
drivers/staging/sm750fb/ddk750.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */

How do you know that is what this license is?

thanks,

greg k-h

author
#2 lore raw
In reply to Sumit Kumar
Quoted 17 lines · Greg Kroah-Hartman
Quoted 13 lines · Sumit Kumar

SPDX licencse identifier is missing in header file. Add a SPDX license identifier with correct format. Issue found by checkpatch.

Signed-off-by Sumit Kumar <[email protected]>
---
  drivers/staging/sm750fb/ddk750.h | 1 +
  1 file changed, 1 insertion(+)
drivers/staging/sm750fb/ddk750.h +0 -0
index 7340103..482c1c6 100644

drivers/staging/sm750fb/ddk750.h line 1

Quoted 1 line
drivers/staging/sm750fb/ddk750.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */

How do you know that is what this license is?

Quoted 3 lines

thanks,

greg k-h

ddk750_chip.h had this license : /* SPDX-License-Identifier: GPL-2.0 */ So I thought that maybe this header should also have the same license.

--
Thanks and Regards,
Sumit

maintainer
#3 lore raw
In reply to Sumit Kumar
Quoted 20 lines · Sumit Kumar
Quoted 17 lines · Greg Kroah-Hartman
Quoted 13 lines · Sumit Kumar

SPDX licencse identifier is missing in header file. Add a SPDX license identifier with correct format. Issue found by checkpatch.

Signed-off-by Sumit Kumar <[email protected]>
---
  drivers/staging/sm750fb/ddk750.h | 1 +
  1 file changed, 1 insertion(+)
drivers/staging/sm750fb/ddk750.h +0 -0
index 7340103..482c1c6 100644

drivers/staging/sm750fb/ddk750.h line 1

Quoted 1 line
drivers/staging/sm750fb/ddk750.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */

How do you know that is what this license is?

Quoted 6 lines
Quoted 3 lines

thanks,

greg k-h

ddk750_chip.h had this license : /* SPDX-License-Identifier: GPL-2.0 */ So I thought that maybe this header should also have the same license.

You need a bit more background information here in order to make this decision in the patch. Please see other patches that have added licenses to files without them for what is needed.

thanks,

greg k-h