Skip to contentSkip to conversation

lib: Remove retry message from TST_RETRY_FUNC

PATCH New Richard Palethorpe 3 participants 3 messages May 4, 2018 – May 9, 2018

lore
Share & tools
lore

Richard Palethorpe

author
#0 lore raw

PATCH 1/1 lib: Remove retry message from TST_RETRY_FUNC

This message creates a lot of noise and uses extra resources on slower machines. It also does not seem very useful.

Signed-off-by Richard Palethorpe <[email protected]>

---

This may help debug test failures on ARM machines by reducing the amount of noise.

 include/tst_common.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
include/tst_common.h +1 -4
index d3d50eb19..27924766e 100644
@@ -56,13 +56,10 @@
 		if (tst_ret_ == ERET)					\
 			break;						\
 		if (tst_delay_ < MAX_DELAY * 1000000) {			\
-			tst_res(TINFO,					\
-				#FUNC" returned %i, retrying"		\
-				" in %ius", tst_ret_, tst_delay_);	\
 			usleep(tst_delay_);				\
 			tst_delay_ *= 2;				\
 		} else {						\
-			tst_brk(TBROK, #FUNC" failed");			\
+			tst_brk(TBROK, #FUNC" timed out");		\
 		}							\
 	}								\
 	ERET;								\
Signature · 1 line
2.16.3
#1 lore raw

PATCH 1/1 lib: Remove retry message from TST_RETRY_FUNC

Quoted 3 lines · Richard Palethorpe

This message creates a lot of noise and uses extra resources on slower machines. It also does not seem very useful.

Yes! That's the reason why I cancel the print message in shell achievement. :)

http://lists.linux.it/pipermail/ltp/2018-May/007968.html​

Signature · 5 lines
Li Wang
[email protected]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180508/7ceea09e/attachment.html>