Skip to contentSkip to conversation

toolchain/buildroot: Fix symbol for uClibc

PATCH Superseded Petr Vorel 2 participants 3 messages May 9, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/2 toolchain/buildroot: Fix symbol for uClibc

Symbol BR2_TOOLCHAIN_UCLIBC doesn't exist, it was meant to be BR2_TOOLCHAIN_BUILDROOT_UCLIBC.

Fixes 493b1177b9 toolchain/buildroot: default to uClibc

---
Error found while working with updated kconfig, which offers this feature.

---
 toolchain/toolchain-buildroot/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
toolchain/toolchain-buildroot/Config.in +1 -1
index 2f6624d217..75e8191f46 100644
@@ -22,7 +22,7 @@ config BR2_TOOLCHAIN_BUILDROOT_VENDOR
 
 choice
 	prompt "C library"
-	default BR2_TOOLCHAIN_UCLIBC
+	default BR2_TOOLCHAIN_BUILDROOT_UCLIBC
 	default BR2_TOOLCHAIN_BUILDROOT_GLIBC if BR2_powerpc64
 
 config BR2_TOOLCHAIN_BUILDROOT_UCLIBC
Signature · 1 line
2.16.3
author
#1 lore raw

PATCH 2/2 package/libmediaart: Fix default symbol for media art backend

Symbol BR2_PACKAGE_LIBMEDIAART_BACKEND_NONE does not exist it was meant to be BR2_PACKAGE_MEDIAART_BACKEND_NONE.

Fixes c443830a57 libmediaart: new package

---
Error found while working with updated kconfig, which offers this feature.

---
 package/libmediaart/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libmediaart/Config.in +1 -1
index e5e770d4fc..d3fea05ac4 100644
@@ -18,7 +18,7 @@ if BR2_PACKAGE_LIBMEDIAART
 
 choice
 	prompt "media art backend"
-	default BR2_PACKAGE_LIBMEDIAART_BACKEND_NONE
+	default BR2_PACKAGE_MEDIAART_BACKEND_NONE
 
 config BR2_PACKAGE_MEDIAART_BACKEND_NONE
 	bool "none"
Signature · 1 line
2.16.3
#2 lore raw

PATCH 2/2 package/libmediaart: Fix default symbol for media art backend

Hello,

Quoted 9 lines · Petr Vorel

Symbol BR2_PACKAGE_LIBMEDIAART_BACKEND_NONE does not exist it was meant to be BR2_PACKAGE_MEDIAART_BACKEND_NONE.

Fixes c443830a57 libmediaart: new package

---
Error found while working with updated kconfig, which offers this feature.

Meh, in fact the real bug is that all those options should be prefixed by BR2_PACKAGE_LIBMEDIAART and not BR2_PACKAGE_MEDIAART.

Could you fix that instead ? Config.in.legacy handling will however not be possible, because those options are part of a Kconfig choice, and you can't select an item of a choice.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com