Skip to contentSkip to conversation

net/i40e: fix missing VLAN offload capability

PATCH Superseded Yanglong Wu 3 participants 6 messages May 10, 2018 – May 11, 2018 Network drivers

lore
Share & tools
lore

Yanglong Wu

author
#0 lore raw

PATCH 1/1 net/i40e: fix missing VLAN offload capability

VLAN offload capability should be exposed both
VF and PF since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
---
 drivers/net/i40e/i40e_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +3 -1
index 894505f98..ad377f440 100644
@@ -3299,7 +3299,9 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
 		DEV_RX_OFFLOAD_VLAN_FILTER |
-		DEV_RX_OFFLOAD_JUMBO_FRAME;
+		DEV_RX_OFFLOAD_JUMBO_FRAME |
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	dev_info->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;
 	dev_info->tx_offload_capa =
Signature · 1 line
2.11.0
#1 lore raw
Quoted 24 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Thursday, May 10, 2018 10:45 AM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Dai, Wei <[email protected]>; Wu, Yanglong <[email protected]>
Subject: [PATCH] net/i40e: fix missing VLAN offload capability

VLAN offload capability should be exposed both VF and PF since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
---
 drivers/net/i40e/i40e_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.c +0 -0
index 894505f98..ad377f440 100644

drivers/net/i40e/i40e_ethdev.c i40e_dev_info_get(struct rte_eth_dev *dev, struct · line 3305

Quoted 8 lines
drivers/net/i40e/i40e_ethdev.c +3 -1
@@ -3299,7 +3299,9 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
 rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_CRC_STRIP |
 		DEV_RX_OFFLOAD_VLAN_EXTEND |
 		DEV_RX_OFFLOAD_VLAN_FILTER |
-		DEV_RX_OFFLOAD_JUMBO_FRAME;
+		DEV_RX_OFFLOAD_JUMBO_FRAME |
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_VLAN_EXTEND;

This is duplicate.
I guess want to add missing flags to i40evf_dev_info_get ?

Quoted 6 lines
drivers/net/i40e/i40e_ethdev.c +0 -0
 	dev_info->tx_queue_offload_capa =
 DEV_TX_OFFLOAD_MBUF_FAST_FREE;

dev_info->tx_offload_capa =
--
2.11.0

author
#2 lore raw

PATCH v2 1/1 net/i40e: fix missing VLAN offload capability

In reply to Yanglong Wu

VLAN offload capability should be exposed in VF
since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework as comments required

---
 drivers/net/i40e/i40e_ethdev_vf.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev_vf.c +3 -1
index b9dea2e5b..33beded37 100644
@@ -2200,7 +2200,9 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_VLAN_FILTER |
+		DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =
Signature · 1 line
2.11.0
author
#3 lore raw

PATCH v2 1/1 net/i40e: fix missing VLAN offload capability

In reply to Yanglong Wu

VLAN offload capability should be exposed in VF
since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework as comments required

---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev_vf.c +2 -1
index b9dea2e5b..2a37b31b2 100644
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_VLAN_FILTER;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =
Signature · 1 line
2.11.0
#4 lore raw

Hi Yanglong
The patch is OK, could you rebase to dpdk-next-net ?
Thanks
Qi

Quoted 37 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Thursday, May 10, 2018 2:51 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Dai, Wei <[email protected]>; Wu, Yanglong <[email protected]>
Subject: [PATCH v2] net/i40e: fix missing VLAN offload capability

VLAN offload capability should be exposed in VF since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework as comments required

---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev_vf.c +2 -1
index b9dea2e5b..2a37b31b2 100644
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct
 rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_VLAN_FILTER;
 
 	dev_info->tx_queue_offload_capa = 0;

dev_info->tx_offload_capa =
--
2.11.0

Acked-by Qi Zhang Applied
#5 lore raw
Quoted 17 lines · Qi Z

Hi Yanglong
The patch is OK, could you rebase to dpdk-next-net ?
Thanks
Qi

Quoted 12 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Thursday, May 10, 2018 2:51 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Dai, Wei <[email protected]>; Wu, Yanglong <[email protected]>
Subject: [PATCH v2] net/i40e: fix missing VLAN offload capability

VLAN offload capability should be exposed in VF since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
Acked-by Qi Zhang <[email protected]>

Applied to dpdk-next-net/master, thanks.