Skip to contentSkip to conversation

net/vhost: do not zero ol_flags in eth_vhost_rx()

PATCH Applied Tiwei Bie 2 participants 3 messages May 10, 2018 – May 16, 2018 Network drivers

lore
Share & tools
lore

Tiwei Bie

author
#0 lore raw

PATCH 1/1 net/vhost: do not zero ol_flags in eth_vhost_rx()

The ol_flags of mbufs returned by rte_vhost_dequeue_burst() contain necessary offload information. It can't be zeroed.

Fixes f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
Cc Jan Blunck <[email protected]>
Cc [email protected]
Reported-by Lei Yao <[email protected]>
Signed-off-by Tiwei Bie <[email protected]>
---
 drivers/net/vhost/rte_eth_vhost.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/vhost/rte_eth_vhost.c +0 -1
index ff5424a92..47fd23eb3 100644
@@ -400,7 +400,6 @@ eth_vhost_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 
 	for (i = 0; likely(i < nb_rx); i++) {
 		bufs[i]->port = r->port;
-		bufs[i]->ol_flags = 0;
 		bufs[i]->vlan_tci = 0;
 
 		if (r->internal->vlan_strip)
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Tiwei Bie

The ol_flags of mbufs returned by rte_vhost_dequeue_burst() contain necessary offload information. It can't be zeroed.

Fixes f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
Cc Jan Blunck<[email protected]>
Cc [email protected]
Quoted 5 lines
Reported-by Lei Yao<[email protected]>
Signed-off-by Tiwei Bie<[email protected]>
---
  drivers/net/vhost/rte_eth_vhost.c | 1 -
  1 file changed, 1 deletion(-)
Reviewed-by Maxime Coquelin <[email protected]>

Thanks,
Maxime

Applied
#2 lore raw
Quoted 10 lines · Maxime Coquelin
Quoted 7 lines · Tiwei Bie

The ol_flags of mbufs returned by rte_vhost_dequeue_burst() contain necessary offload information. It can't be zeroed.

Fixes f63d356ee993 ("net/vhost: insert/strip VLAN header in software")
Cc Jan Blunck<[email protected]>
Cc [email protected]
Quoted 7 lines
Quoted 5 lines
Reported-by Lei Yao<[email protected]>
Signed-off-by Tiwei Bie<[email protected]>

---
  drivers/net/vhost/rte_eth_vhost.c | 1 -

  1 file changed, 1 deletion(-)
Reviewed-by Maxime Coquelin <[email protected]>

Applied to dpdk-next-virtio/master with commit message reworded to:

net/vhost: do not clear offload flags in Rx

Quoted 2 lines

Thanks,
Maxime