Skip to contentSkip to conversation

batman-adv: fix argument name in kernel-doc

PATCH In review Antonio Quartulli 2 participants 3 messages May 10, 2018 Batman advanced

lore
Share & tools
lore

Antonio Quartulli

author
#0 lore raw

PATCH 1/1 batman-adv: fix argument name in kernel-doc

Signed-off-by Antonio Quartulli <[email protected]>
---
 net/batman-adv/tp_meter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/batman-adv/tp_meter.c +1 -1
index 11520de9..55d8e4c1 100644
@@ -808,7 +808,7 @@ static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen)
 
 /**
  * batadv_tp_send() - main sending thread of a tp meter session
- * @arg: address of the related tp_vars
+ * @work: address of the related tp_vars
  *
  * Return: nothing, this function never returns
  */
Signature · 1 line
2.17.0
maintainer
#1 lore raw
Quoted 11 lines · On Donnerstag, 10. Mai 2018 17:29:46 CEST Antonio Quartulli wrote:
Signed-off-by Antonio Quartulli <[email protected]>
---
 net/batman-adv/tp_meter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/batman-adv/tp_meter.c +0 -0
index 11520de9..55d8e4c1 100644

net/batman-adv/tp_meter.c static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen) · line 814

Quoted 8 lines
net/batman-adv/tp_meter.c +1 -1
@@ -808,7 +808,7 @@ static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen)
 
 /**
  * batadv_tp_send() - main sending thread of a tp meter session
- * @arg: address of the related tp_vars
+ * @work: address of the related tp_vars
  *
  * Return: nothing, this function never returns
  */

Just checked the master branch and the argument is still called arg there:

/**
* batadv_tp_send() - main sending thread of a tp meter session
* @arg: address of the related tp_vars
*
* Return: nothing, this function never returns
*/
static int batadv_tp_send(void *arg)
{

So I will reject this patch.

Kind regards,
Sven

author
#2 lore raw
Quoted 32 lines · Sven Eckelmann
Quoted 11 lines · On Donnerstag, 10. Mai 2018 17:29:46 CEST Antonio Quartulli wrote:
Signed-off-by Antonio Quartulli <[email protected]>
---
 net/batman-adv/tp_meter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/batman-adv/tp_meter.c +0 -0
index 11520de9..55d8e4c1 100644

net/batman-adv/tp_meter.c static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen) · line 814

Quoted 8 lines
net/batman-adv/tp_meter.c +1 -1
@@ -808,7 +808,7 @@ static int batadv_tp_wait_available(struct batadv_tp_vars *tp_vars, size_t plen)
 
 /**
  * batadv_tp_send() - main sending thread of a tp meter session
- * @arg: address of the related tp_vars
+ * @work: address of the related tp_vars
  *
  * Return: nothing, this function never returns
  */

Just checked the master branch and the argument is still called arg there:

/**
* batadv_tp_send() - main sending thread of a tp meter session
* @arg: address of the related tp_vars
*
* Return: nothing, this function never returns
*/
static int batadv_tp_send(void *arg)
{

Quoted 1 line

So I will reject this patch.

Agreed and sorry for the mistake. This must be coming from another new branch we are currently working on.

Cheers,

Signature · 1 line
Antonio Quartulli