Skip to contentSkip to conversation

ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static

PATCH Applied Mathieu Malaterre 3 participants 3 messages May 5, 2018 – May 10, 2018 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static

Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static, make it so. Remove the following gcc warning (W=1):

fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes]

---
 fs/ext4/fsmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ext4/fsmap.c +2 -2
index e871c4bf18e9..4b99e2db95b8 100644
@@ -402,8 +402,8 @@ static void ext4_getfsmap_free_fixed_metadata(struct list_head *meta_list)
 }
 
 /* Find all the fixed metadata in the filesystem. */
-int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
-				      struct list_head *meta_list)
+static int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
+					     struct list_head *meta_list)
 {
 	struct ext4_group_desc *gdp;
 	ext4_group_t agno;
Signature · 1 line
2.11.0
maintainer Applied
#1 lore raw
Quoted 6 lines · Mathieu Malaterre

Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static, make it so. Remove the following gcc warning (W=1):

fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes]

Applied, thanks.

- Ted

Reviewed-by on v1 1/1
#2 lore raw
In reply to Mathieu Malaterre
Quoted 6 lines · Mathieu Malaterre

Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static, make it so. Remove the following gcc warning (W=1):

fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes]

Sorry about being late to the party,

--D

Quoted 22 lines
---
 fs/ext4/fsmap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ext4/fsmap.c +2 -2
index e871c4bf18e9..4b99e2db95b8 100644
@@ -402,8 +402,8 @@ static void ext4_getfsmap_free_fixed_metadata(struct list_head *meta_list)
 }
 
 /* Find all the fixed metadata in the filesystem. */
-int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
-				      struct list_head *meta_list)
+static int ext4_getfsmap_find_fixed_metadata(struct super_block *sb,
+					     struct list_head *meta_list)
 {
 	struct ext4_group_desc *gdp;
 	ext4_group_t agno;
Signature · 1 line
2.11.0