Skip to contentSkip to conversation

powerpc: kvm: Change return type to vm_fault_t

PATCH In review Souptick Joarder 2 participants 4 messages May 10, 2018 – May 16, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 powerpc: kvm: Change return type to vm_fault_t

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
v2: Updated the change log

 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/book3s_64_vio.c +1 -1
index 4dffa61..346ac0d 100644
@@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head)
 	kfree(stt);
 }
 
-static int kvm_spapr_tce_fault(struct vm_fault *vmf)
+static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf)
 {
 	struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data;
 	struct page *page;

--
1.9.1

#1 lore raw
Quoted 31 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
v2: Updated the change log

 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/book3s_64_vio.c +1 -2
index 4dffa61..346ac0d 100644
@@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head)
        kfree(stt);
 }
 
-static int kvm_spapr_tce_fault(struct vm_fault *vmf)
+static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf)
 {
        struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data;
        struct page *page;
--
Quoted 2 lines

1.9.1

If no comment, we would like to get this patch in queue for 4.18.

#2 lore raw
Quoted 26 lines · Souptick Joarder
Quoted 25 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
v2: Updated the change log

 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/book3s_64_vio.c +0 -0
index 4dffa61..346ac0d 100644
@@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head)
        kfree(stt);
 }
 
Quoted 11 lines
Quoted 8 lines
arch/powerpc/kvm/book3s_64_vio.c +1 -2
-static int kvm_spapr_tce_fault(struct vm_fault *vmf)
+static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf)
 {
        struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data;
        struct page *page;
--

1.9.1

If no comment, we would like to get this patch in queue for 4.18.

It looks fine - I'll queue it up.

Paul.

#3 lore raw
Quoted 39 lines · Paul Mackerras
Quoted 26 lines · Souptick Joarder
Quoted 25 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

---
v2: Updated the change log

 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/book3s_64_vio.c +0 -0
index 4dffa61..346ac0d 100644
@@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head)
        kfree(stt);
 }
 
Quoted 11 lines
Quoted 8 lines
arch/powerpc/kvm/book3s_64_vio.c +1 -2
-static int kvm_spapr_tce_fault(struct vm_fault *vmf)
+static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf)
 {
        struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data;
        struct page *page;
--

1.9.1

If no comment, we would like to get this patch in queue for 4.18.

Quoted 3 lines

It looks fine - I'll queue it up.

Paul.

Thanks Paul :)