drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk
Subsystems (2)
PATCH 1/1 drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk
Factor in clear values wherever required while updating destination min/max.
References: HSDES#1604444184
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_workarounds.c | 4 ++++ 2 files changed, 7 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -7251,6 +7251,9 @@ enum {#define SLICE_ECO_CHICKEN0 _MMIO(0x7308)#define PIXEL_MASK_CAMMING_DISABLE (1 << 14) +#define GEN9_WM_CHICKEN3 _MMIO(0x5588) +#define GEN9_FACTOR_IN_CLR_VAL_HIZ (1 << 9) +/* WaCatErrorRejectionIssue */ #define GEN7_SQ_CHICKEN_MBCUNIT_CONFIG _MMIO(0x9030)#define GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB (1<<11)
drivers/gpu/drm/i915/intel_workarounds.c +4 -0
@@ -270,6 +270,10 @@ static int gen9_ctx_workarounds_init(struct drm_i915_private *dev_priv)GEN9_PREEMPT_GPGPU_LEVEL_MASK , GEN9_PREEMPT_GPGPU_COMMAND_LEVEL); +/* WaClearHIZ_WM_CHICKEN3:bxt,glk */ +if (IS_GEN9_LP (dev_priv)) +WA_SET_BIT_MASKED (GEN9_WM_CHICKEN3 ,GEN9_FACTOR_IN_CLR_VAL_HIZ ); +return 0 ; }
Signature · 6 lines
2.17.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk
== Series Details ==
== Series Details ==
Series: drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk
URL : https://patchwork.freedesktop.org/series/43024/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4164 -> Patchwork_8975 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43024/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8975 that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-cnl-psr: DMESG-WARN (fdo#104951) -> PASSfdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
== Participating hosts (40 -> 36) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4164 -> Patchwork_8975
CI_DRM_4164: a44969bdb6d69244a063eac7f76ea46353960409 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4475: 35f08c12aa216d5b62a5b9984b575cee6905098f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8975: 381f5f305fccb06be385915c40ed40c0feacdb49 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4475: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit
== Linux commits ==
381f5f305fcc drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8975/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk
In reply to Michel Thierry== Series Details ==
== Series Details ==
Series: drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk
URL : https://patchwork.freedesktop.org/series/43024/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4164_full -> Patchwork_8975_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8975_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_8975_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43024/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8975_full:
=== IGT changes ===
==== Warnings ====
igt@gem_pwrite@big-cpu-random:
shard-glk: SKIP -> PASS
igt@kms_atomic@plane_primary_legacy:
shard-snb: PASS -> SKIP== Known issues ==
Here are the changes found in Patchwork_8975_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: PASS -> INCOMPLETE (fdo#103665, fdo#106023)
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-snb: PASS -> DMESG-WARN (fdo#102365)
igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
shard-hsw: PASS -> DMESG-WARN (fdo#102614)
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_flip@flip-vs-wf_vblank-interruptible:
shard-apl: PASS -> FAIL (fdo#105312)
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: PASS -> FAIL (fdo#100368) +2
==== Possible fixes ====
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_flip@plain-flip-ts-check:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
shard-hsw: DMESG-FAIL (fdo#104724, fdo#103167) -> PASS
igt@kms_setmode@basic:
shard-hsw: FAIL (fdo#99912) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105312 https://bugs.freedesktop.org/show_bug.cgi?id=105312
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (9 -> 9) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4164 -> Patchwork_8975
CI_DRM_4164: a44969bdb6d69244a063eac7f76ea46353960409 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4475: 35f08c12aa216d5b62a5b9984b575cee6905098f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8975: 381f5f305fccb06be385915c40ed40c0feacdb49 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4475: 3ba0657bff4216d1ec7179935590261855f1651e @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8975/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Michel Thierry
Factor in clear values wherever required while updating destination min/max.
References: HSDES#1604444184
Signed-off-by Michel Thierry <[email protected]>Cc Mika Kuoppala <[email protected]>Cc Oscar Mateo <[email protected]>
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Mika Kuoppala (2018-05-11 10:56:49)
Quoted 5 lines
Quoted 3 lines · Michel Thierry
Factor in clear values wherever required while updating destination min/max.
Quoted 7 lines
Quoted 5 lines
References: HSDES#1604444184
Signed-off-by Michel Thierry <[email protected]>Cc Mika Kuoppala <[email protected]>Cc Oscar Mateo <[email protected]>Reviewed-by Mika Kuoppala <[email protected]>
Cc: stable?
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Chris Wilson
Quoting Mika Kuoppala (2018-05-11 10:56:49)
Quoted 11 lines
Quoted 8 lines · Michel Thierry
Factor in clear values wherever required while updating destination min/max.
References: HSDES#1604444184
Signed-off-by Michel Thierry <[email protected]>Cc Mika Kuoppala <[email protected]>Cc Oscar Mateo <[email protected]>
Quoted 3 lines
Quoted 1 line
Reviewed-by Mika Kuoppala <[email protected]>Cc stable?
Yes, we should.
-Mika
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 14 lines · Mika Kuoppala
Quoted 12 lines · Chris Wilson
Quoting Mika Kuoppala (2018-05-11 10:56:49)
Quoted 11 lines
Quoted 8 lines · Michel Thierry
Factor in clear values wherever required while updating destination min/max.
References: HSDES#1604444184
Signed-off-by Michel Thierry <[email protected]>Cc Mika Kuoppala <[email protected]>Cc Oscar Mateo <[email protected]>
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Reviewed-by Mika Kuoppala <[email protected]>Cc stable?Yes, we should.
I think so too, although stable doesn't have the workaround refactoring yet, the change will be in intel_engine_cs.c instead.
Quoted 2 lines
-Mika
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Michel Thierry (2018-05-11 16:07:55)
Quoted 17 lines · Mika Kuoppala
Quoted 16 lines
Quoted 14 lines · Chris Wilson
Quoting Mika Kuoppala (2018-05-11 10:56:49)
Quoted 12 lines
Quoted 8 lines · Michel Thierry
Factor in clear values wherever required while updating destination min/max.
References: HSDES#1604444184
Signed-off-by Michel Thierry <[email protected]>Cc Mika Kuoppala <[email protected]>Cc Oscar Mateo <[email protected]>Reviewed-by Mika Kuoppala <[email protected]>
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Cc stable?Yes, we should.
I think so too, although stable doesn't have the workaround refactoring yet, the change will be in
intel_engine_cs.cinstead.
Added the cc for stable, and pushed. We may need to send a fixup patch later if we want it backported all the way.
Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx