Skip to contentSkip to conversation

SSB cleanup fix of cleanup fix.

PATCH In review [email protected] 2 participants 2 messages May 10, 2018 – May 11, 2018

Subsystems (2)
x86 x86 hardware vulnerabilities
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 SSB cleanup fix of cleanup fix.

Fixes 7bb4d366c ("x86/bugs: Make cpu_show_common() static")
Signed-off-by Konrad Rzeszutek Wilk <[email protected]>
---
 arch/x86/kernel/cpu/bugs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/bugs.c +1 -1
index 784753f0b41e..f5143fc12a45 100644
@@ -641,7 +641,7 @@ void x86_spec_ctrl_setup_ap(void)
 #ifdef CONFIG_SYSFS
 
 static ssize_t cpu_show_common(struct device *dev, struct device_attribute *attr,
-			char *buf, unsigned int bug)
+			       char *buf, unsigned int bug)
 {
 	if (!boot_cpu_has_bug(bug))
 		return sprintf(buf, "Not affected\n");
Signature · 1 line
2.14.3
#1 lore raw

arch/x86/kernel/cpu/bugs.c void x86_spec_ctrl_setup_ap(void) · line 644

Quoted 10 lines · speck for konrad.wilk_at_oracle.com
arch/x86/kernel/cpu/bugs.c +1 -1
index 784753f0b41e..f5143fc12a45 100644
@@ -641,7 +641,7 @@ void x86_spec_ctrl_setup_ap(void)
 #ifdef CONFIG_SYSFS
 
 static ssize_t cpu_show_common(struct device *dev, struct device_attribute *attr,
-			char *buf, unsigned int bug)
+			       char *buf, unsigned int bug)

While you're doing with trivial prototype fixups, maybe it'd be worth to make ssb_select_mitigation() prototype proper ANSI C at the same time.

arch/x86/kernel/cpu/bugs.c +1 -1
index 784753f0b41e..73ba66714765 100644
@@ -531,7 +531,7 @@ static enum ssb_mitigation __init __ssb_select_mitigation(void)
 	return mode;
 }
 
-static void ssb_select_mitigation()
+static void ssb_select_mitigation(void)
 {
 	ssb_mode = __ssb_select_mitigation();
Signature · 2 lines
Jiri Kosina
SUSE Labs