Skip to contentSkip to conversation

musb: fix remote wakeup racing with suspend

PATCH New Bin Liu 1 participant 1 message May 11, 2018 USB

lore
Share & tools
lore

Bin Liu

author Applied
#0 lore raw

PATCH v2 1/1 musb: fix remote wakeup racing with suspend

Hi,

Quoted 8 lines · Daniel Glöckner

It has been observed that writing 0xF2 to the power register while it reads as 0xF4 results in the register having the value 0xF0, i.e. clearing RESUME and setting SUSPENDM in one go does not work. It might also violate the USB spec to transition directly from resume to suspend, especially when not taking T_DRSMDN into account. But this is what happens when a remote wakeup occurs between SetPortFeature USB_PORT_FEAT_SUSPEND on the root hub and musb_bus_suspend being called.

Quoted 5 lines

This commit returns -EBUSY when musb_bus_suspend is called while remote wakeup is signalled and thus avoids to reset the RESUME bit. Ignoring this error when musb_port_suspend is called from musb_hub_control is ok.

Applied. Thanks.

Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html