Skip to contentSkip to conversation

strace: disable (again) mpers for musl

PATCH New Baruch Siach 2 participants 2 messages May 10, 2018 – May 11, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 strace: disable (again) mpers for musl

It turns out that mpers support in strace still does not play nicely with musl libc. As explained in commit 7892a778b (package/strace:
disable libmpers with musl toolchains) headers mixup causes gcc header to be included, instead of the musl one, resulting in conflicting types. Commit 1088372941 (strace: bump to version 4.21) incorrectly enabled mpers for musl. Revert that.

Fixes:
http://autobuild.buildroot.net/results/345/3452419498c074ca66f36f0f87263fa10662ac86/

---
 package/strace/strace.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/strace/strace.mk +8 -0
index 0529d79af6fb..1cb0c88c4f3e 100644
@@ -11,6 +11,14 @@ STRACE_LICENSE = BSD-3-Clause
 STRACE_LICENSE_FILES = COPYING
 STRACE_CONF_OPTS = --enable-mpers=check
 
+# strace bundle some kernel headers to build libmpers, this mixes userspace
+# headers and kernel headers which break the build with musl.
+# The stddef.h from gcc is used instead of the one from musl.
+ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
+STRACE_CONF_OPTS += st_cv_m32_mpers=no \
+	st_cv_mx32_mpers=no
+endif
+
 ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
 STRACE_DEPENDENCIES += libunwind
 STRACE_CONF_OPTS += --with-libunwind
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 strace: disable (again) mpers for musl

Hello,

Quoted 7 lines · Baruch Siach

It turns out that mpers support in strace still does not play nicely with musl libc. As explained in commit 7892a778b (package/strace:
disable libmpers with musl toolchains) headers mixup causes gcc header to be included, instead of the musl one, resulting in conflicting types. Commit 1088372941 (strace: bump to version 4.21) incorrectly enabled mpers for musl. Revert that.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/345/3452419498c074ca66f36f0f87263fa10662ac86/

---
 package/strace/strace.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com