befs_lookup(): use d_splice_alias()

RFC PATCH New Al Viro 1 participant 1 message May 13, 2018

Subsystems (2)

VFS Befs file system

lore

Share & tools

lore

Al Viro

author maintainer

2018-05-13 16:23 UTC #0 lore raw

RFC PATCH 1/1 befs_lookup(): use d_splice_alias()

RTFS(Documentation/filesystems/nfs/Exporting) if you try to make something exportable.

Fixes ac632f5b6301 "befs: add NFS export support"

Signed-off-by Al Viro <[email protected]>

fs/befs/linuxvfs.c +5 ~~-12~~

index af2832aaeec5..4700b4534439 100644
@@ -198,23 +198,16 @@ befs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
 
 	if (ret == BEFS_BT_NOT_FOUND) {
 		befs_debug(sb, "<--- %s %pd not found", __func__, dentry);
-		d_add(dentry, NULL);
-		return ERR_PTR(-ENOENT);
-
+		inode = NULL;
 	} else if (ret != BEFS_OK || offset == 0) {
 		befs_error(sb, "<--- %s Error", __func__);
-		return ERR_PTR(-ENODATA);
+		inode = ERR_PTR(-ENODATA);
+	} else {
+		inode = befs_iget(dir->i_sb, (ino_t) offset);
 	}
-
-	inode = befs_iget(dir->i_sb, (ino_t) offset);
-	if (IS_ERR(inode))
-		return ERR_CAST(inode);
-
-	d_add(dentry, inode);
-
 	befs_debug(sb, "<--- %s", __func__);
 
-	return NULL;
+	return d_splice_alias(inode, dentry);
 }
 
 static int