Skip to contentSkip to conversation

libkrb5: disable rpath

PATCH New Baruch Siach 4 participants 5 messages May 13, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libkrb5: disable rpath

The default rpath value for krb5 is /usr/lib. On some hosts this might confuse the build time linker as it looks for target libraries in the host /usr/lib directory.

Should fix:
http://autobuild.buildroot.net/results/6df/6df84ed325ddd92248741d2f4737423b1b999489/
http://autobuild.buildroot.net/results/049/049f5147288b418402b6e5a4181eff4d426c8d7a/
http://autobuild.buildroot.net/results/432/432d5d0295f77cd34b78e70e8b4b7d77ef19ae3c/

---
 package/libkrb5/libkrb5.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libkrb5/libkrb5.mk +2 -1
index c40be632786b..d9d7160ae8d5 100644
@@ -28,7 +28,8 @@ LIBKRB5_CONF_OPTS = \
 	--without-system-et \
 	--without-system-ss \
 	--without-system-verto \
-	--without-tcl
+	--without-tcl \
+	--disable-rpath
 
 ifeq ($(BR2_PACKAGE_OPENLDAP),y)
 LIBKRB5_CONF_OPTS += --with-ldap
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 libkrb5: disable rpath

Am 13.05.2018 um 20:37 schrieb Baruch Siach:

Quoted 20 lines

The default rpath value for krb5 is /usr/lib. On some hosts this might confuse the build time linker as it looks for target libraries in the host /usr/lib directory.

Should fix:
http://autobuild.buildroot.net/results/6df/6df84ed325ddd92248741d2f4737423b1b999489/
http://autobuild.buildroot.net/results/049/049f5147288b418402b6e5a4181eff4d426c8d7a/
http://autobuild.buildroot.net/results/432/432d5d0295f77cd34b78e70e8b4b7d77ef19ae3c/

---
 package/libkrb5/libkrb5.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libkrb5/libkrb5.mk +0 -0
index c40be632786b..d9d7160ae8d5 100644

package/libkrb5/libkrb5.mk LIBKRB5_CONF_OPTS = \ · line 35

Quoted 9 lines
package/libkrb5/libkrb5.mk +2 -1
@@ -28,7 +28,8 @@ LIBKRB5_CONF_OPTS = \
 	--without-system-et \
 	--without-system-ss \
 	--without-system-verto \
-	--without-tcl
+	--without-tcl \
+	--disable-rpath
 
 ifeq ($(BR2_PACKAGE_OPENLDAP),y)
 LIBKRB5_CONF_OPTS += --with-ldap

Thank you!
Sorry for not catching those myself, I just had no clue what was going on here and with the other failures.

#2 lore raw

PATCH 1/1 libkrb5: disable rpath

Andr?, All,

On 2018-05-13 20:59 +0200, Andr? Hentschel spake thusly:

Quoted 27 lines

Am 13.05.2018 um 20:37 schrieb Baruch Siach:

Quoted 26 lines

The default rpath value for krb5 is /usr/lib. On some hosts this might confuse the build time linker as it looks for target libraries in the host /usr/lib directory.

Should fix:
http://autobuild.buildroot.net/results/6df/6df84ed325ddd92248741d2f4737423b1b999489/
http://autobuild.buildroot.net/results/049/049f5147288b418402b6e5a4181eff4d426c8d7a/
http://autobuild.buildroot.net/results/432/432d5d0295f77cd34b78e70e8b4b7d77ef19ae3c/

---
 package/libkrb5/libkrb5.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libkrb5/libkrb5.mk +2 -1
index c40be632786b..d9d7160ae8d5 100644
@@ -28,7 +28,8 @@ LIBKRB5_CONF_OPTS = \
 	--without-system-et \
 	--without-system-ss \
 	--without-system-verto \
-	--without-tcl
+	--without-tcl \
+	--disable-rpath
 
Quoted 8 lines

package/libkrb5/libkrb5.mk LIBKRB5_CONF_OPTS = \ · line 35

Quoted 3 lines
package/libkrb5/libkrb5.mk +0 -0
 ifeq ($(BR2_PACKAGE_OPENLDAP),y)
 LIBKRB5_CONF_OPTS += --with-ldap

Thank you!
Sorry for not catching those myself, I just had no clue what was going on here and with the other failures.

"Signed-off-by" is when you are part of the submission chain, i.e. you participated in the chain that goes from the author down to the one that sends it on the mailing list.

If you agree with a patch, you can provide:

Reviewed-by: you looked at the patch, it looks OK for you, but you
can't guarantee there so side effect;

Acked-by: same as Reviewed-by, but you would commit it if you had
commit rights;

Tested-by you actually tested the patch, and it behaves as expected.

Regards,
Yann E. MORIN.

Quoted 3 lines

buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 libkrb5: disable rpath

In reply to Baruch Siach

Baruch,

Added Matthew in Cc, as the failures only occur on hios autobuilder, as I could see...

Matthew, not sure you saw my request on IRC: were you able to test the same fix I shared on IRC?

On 2018-05-13 21:37 +0300, Baruch Siach spake thusly:

Quoted 10 lines

The default rpath value for krb5 is /usr/lib. On some hosts this might confuse the build time linker as it looks for target libraries in the host /usr/lib directory.

Should fix:
http://autobuild.buildroot.net/results/6df/6df84ed325ddd92248741d2f4737423b1b999489/
http://autobuild.buildroot.net/results/049/049f5147288b418402b6e5a4181eff4d426c8d7a/
http://autobuild.buildroot.net/results/432/432d5d0295f77cd34b78e70e8b4b7d77ef19ae3c/

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/libkrb5/libkrb5.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libkrb5/libkrb5.mk +2 -1
index c40be632786b..d9d7160ae8d5 100644
@@ -28,7 +28,8 @@ LIBKRB5_CONF_OPTS = \
 	--without-system-et \
 	--without-system-ss \
 	--without-system-verto \
-	--without-tcl
+	--without-tcl \
+	--disable-rpath
 
 ifeq ($(BR2_PACKAGE_OPENLDAP),y)
 LIBKRB5_CONF_OPTS += --with-ldap
Signature · 6 lines
2.17.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 libkrb5: disable rpath

In reply to Baruch Siach

Hello,

Quoted 9 lines · Baruch Siach

The default rpath value for krb5 is /usr/lib. On some hosts this might confuse the build time linker as it looks for target libraries in the host /usr/lib directory.

Should fix:
http://autobuild.buildroot.net/results/6df/6df84ed325ddd92248741d2f4737423b1b999489/
http://autobuild.buildroot.net/results/049/049f5147288b418402b6e5a4181eff4d426c8d7a/
http://autobuild.buildroot.net/results/432/432d5d0295f77cd34b78e70e8b4b7d77ef19ae3c/

Quoted 4 lines
---
 package/libkrb5/libkrb5.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com