Skip to contentSkip to conversation

bfs_lookup(): use d_splice_alias()

RFC PATCH In review Al Viro 2 participants 2 messages May 13, 2018 VFS

lore
Share & tools
lore

Al Viro

author
#0 lore raw

RFC PATCH 1/1 bfs_lookup(): use d_splice_alias()

code is actually simpler that way.

Signed-off-by Al Viro <[email protected]>
---
 fs/bfs/dir.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
fs/bfs/dir.c +1 -6
index ee832ca5f734..facf9614a381 100644
@@ -141,14 +141,9 @@ static struct dentry *bfs_lookup(struct inode *dir, struct dentry *dentry,
 		unsigned long ino = (unsigned long)le16_to_cpu(de->ino);
 		brelse(bh);
 		inode = bfs_iget(dir->i_sb, ino);
-		if (IS_ERR(inode)) {
-			mutex_unlock(&info->bfs_lock);
-			return ERR_CAST(inode);
-		}
 	}
 	mutex_unlock(&info->bfs_lock);
-	d_add(dentry, inode);
-	return NULL;
+	return d_splice_alias(inode, dentry);
 }
 
 static int bfs_link(struct dentry *old, struct inode *dir,
Signature · 1 line
2.11.0
maintainer
#1 lore raw

Arrrrghh... Buggered script, sorry for bogus Cc lists...