Skip to contentSkip to conversation

autobuild-run: enforce a sane umask

PATCH New Yann E. MORIN 2 participants 2 messages Jan 9, 2018 – May 13, 2018

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 autobuild-run: enforce a sane umask

When the umask of the user the autobuild-run script runs as is not what Buildroot expects, Buildroot will respawn another make instance with the expected umask.

However, in case of failure, the error message of the inner make are printed, followed by the error message of the outter make. And we are interested to catch only the errors from the inner make (the real one).

This means that we can miss the reason for the failure.

So we enforce a correct umask value from within the autobuild-run script itself.

Reported-by Matthew Weber <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Matthew Weber <[email protected]>
---
 scripts/autobuild-run | 5 +++++
 1 file changed, 5 insertions(+)
scripts/autobuild-run +5 -0
index 2949417..b3f3c65 100755
@@ -666,6 +666,11 @@ def main():
     if not sysinfo.check_requirements():
         sys.exit(1)
 
+    # Enforce the sanest umask here, to avoid buildroot doing it on its
+    # own and causing a double-make call, thus adding extraneous lines
+    # in case of failures.
+    os.umask(0022)
+
     def sigterm_handler(signum, frame):
         """Kill all children"""
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 autobuild-run: enforce a sane umask

Hello,

Quoted 13 lines · Yann E. MORIN

When the umask of the user the autobuild-run script runs as is not what Buildroot expects, Buildroot will respawn another make instance with the expected umask.

However, in case of failure, the error message of the inner make are printed, followed by the error message of the outter make. And we are interested to catch only the errors from the inner make (the real one).

This means that we can miss the reason for the failure.

So we enforce a correct umask value from within the autobuild-run script itself.

Quoted 7 lines
Reported-by Matthew Weber <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Matthew Weber <[email protected]>
---
 scripts/autobuild-run | 5 +++++
 1 file changed, 5 insertions(+)

Applied to buildroot-test. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com