nvme: Add command timeout injection test
Subsystems (2)
PATCH v2 1/1 nvme: Add command timeout injection test
This test will run a background IO process and inject an admin command with a very short timeout that is all but guaranteed to expire without a completion: the async event request.
---
v1 -> v2:
Changed description since its not a test for a specific regression-fixing patch.
Added fio requirement.
Missing quotes around device name.
tests/nvme/005 | 42 ++++++++++++++++++++++++++++++++++++++++++ tests/nvme/005.out | 3 +++ 2 files changed, 45 insertions(+) create mode 100755 tests/nvme/005 create mode 100644 tests/nvme/005.out
tests/nvme/005 new file +42 -0
@@ -0,0 +1,42 @@ +#!/bin/bash +# +# Test for nvme timeout handling with inflight IO. +# +# Copyright (C) 2018 Keith Busch <[email protected]> +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +DESCRIPTION="test nvme admin command timeout handling with in-flight io" + +QUICK=1 + +requires() { + _have_fio && _have_program nvme +} + +test_device() { + echo "Running ${TEST_NAME}" + + # start fio job + _run_fio_rand_io --filename="${TEST_DEV}" --time_based --runtime=20 & + + sleep 5 + + # send nvme admin command 'async event request', which will surely time out + nvme admin-passthru "${TEST_DEV}" -o 0xc --timeout=1 + + wait + + echo "Test complete" +}
tests/nvme/005.out new file +3 -0
@@ -0,0 +1,3 @@ +Running nvme/005 +passthru: Interrupted system call +Test complete
Signature · 1 line
2.14.3
Quoted 8 lines · Keith Busch
This test will run a background IO process and inject an admin command with a very short timeout that is all but guaranteed to expire without a completion: the async event request.
Signed-off-by Keith Busch <keith.busch at intel.com>---
v1 -> v2:
Quoted 6 lines
Changed description since its not a test for a specific regression-fixing patch.
Added fio requirement.
Missing quotes around device name.
I tried this on my QEMU VM, which apparently doesn't emulate this command:
$ sudo ./check nvme/006
nvme/006 => nvme0n1 (test nvme admin command timeout handling with in-flight io) [failed]
runtime ... 20.505s
--- tests/nvme/006.out 2018-05-14 13:43:31.150443366 -0700
+++ results/nvme0n1/nvme/006.out.bad 2018-05-14 13:57:39.334671448 -0700
@@ -1,3 +1,3 @@
Running nvme/006
-passthru: Interrupted system call
+NVMe Status:INVALID_OPCODE(4001) Command Result:00000000
Test completeCan this test use a loopback target like the nvme tests Johannes has added recently?
Quoted 66 lines
tests/nvme/005 | 42 ++++++++++++++++++++++++++++++++++++++++++ tests/nvme/005.out | 3 +++ 2 files changed, 45 insertions(+) create mode 100755 tests/nvme/005 create mode 100644 tests/nvme/005.outtests/nvme/005 new file +42
-0@@ -0,0 +1,42 @@ +#!/bin/bash +# +# Test for nvme timeout handling with inflight IO. +# +# Copyright (C) 2018 Keith Busch <keith.busch at intel.com> +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +DESCRIPTION="test nvme admin command timeout handling with in-flight io" + +QUICK=1 + +requires() { + _have_fio && _have_program nvme +} + +test_device() { + echo "Running ${TEST_NAME}" + + # start fio job + _run_fio_rand_io --filename="${TEST_DEV}" --time_based --runtime=20 & + + sleep 5 + + # send nvme admin command 'async event request', which will surely time out + nvme admin-passthru "${TEST_DEV}" -o 0xc --timeout=1 + + wait + + echo "Test complete" +}tests/nvme/005.out new file +3
-0@@ -0,0 +1,3 @@ +Running nvme/005 +passthru: Interrupted system call +Test completeSignature · 1 line
2.14.3
Quoted 12 lines · Omar Sandoval
Quoted 11 lines · Keith Busch
This test will run a background IO process and inject an admin command with a very short timeout that is all but guaranteed to expire without a completion: the async event request.
Signed-off-by Keith Busch <[email protected]>---
v1 -> v2:Changed description since its not a test for a specific regression-fixing patch.
Quoted 6 lines
Quoted 3 lines
Added fio requirement.
Missing quotes around device name.
I tried this on my QEMU VM, which apparently doesn't emulate this command:
Ah, qemu mainline isn't spec compliant and doesn't support AEN requests. I was testing on real hardware.
This older one has support:
http://git.infradead.org/users/kbusch/qemu-nvme.git/
It is quite old, though.
Quoted 2 lines
Can this test use a loopback target like the nvme tests Johannes has added recently?
It looks like the in-kernel nvme target supports it. I'll have to give it a try.