Skip to contentSkip to conversation

phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy_probe()

PATCH In review Douglas Anderson 2 participants 5 messages May 14, 2018 – Aug 10, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy_probe()

The -EPROBE_DEFER virus demands special case code to avoid printing error messages when the error is only -EPROBE_DEFER. Spread the virus to a new host: qcom_qmp_phy_probe(). Specifically handle when our regulators might not be ready yet.

---

 drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-qmp.c +3 -1
index 6470c5d61d1c..a740daa58b31 100644
@@ -1447,7 +1447,9 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
 
 	ret = qcom_qmp_phy_vreg_init(dev);
 	if (ret) {
-		dev_err(dev, "failed to get regulator supplies\n");
+		if (ret != -EPROBE_DEFER)
+			dev_err(dev, "failed to get regulator supplies: %d\n",
+				ret);
 		return ret;
 	}
 
Signature · 1 line
2.17.0.441.gb46fe60e1d-goog
#1 lore raw

PATCH 2/2 phy: qcom-qusb2: Quiet -EPROBE_DEFER from qusb2_phy_probe()

The -EPROBE_DEFER virus demands special case code to avoid printing error messages when the error is only -EPROBE_DEFER. Spread the virus to a new host: qusb2_phy_probe(). Specifically handle when our regulators might not be ready yet.

---

 drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-qusb2.c +3 -1
index 94afeac1a19e..26354618fd45 100644
@@ -711,7 +711,9 @@ static int qusb2_phy_probe(struct platform_device *pdev)
 
 	ret = devm_regulator_bulk_get(dev, num, qphy->vregs);
 	if (ret) {
-		dev_err(dev, "failed to get regulator supplies\n");
+		if (ret != -EPROBE_DEFER)
+			dev_err(dev, "failed to get regulator supplies: %d\n",
+				ret);
 		return ret;
 	}
 
Signature · 1 line
2.17.0.441.gb46fe60e1d-goog
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] phy: qcom-qusb2: Quiet -EPROBE_DEFER from qusb2_phy_probe()

Hi Doug,

Quoted 16 lines · Douglas Anderson

The -EPROBE_DEFER virus demands special case code to avoid printing error messages when the error is only -EPROBE_DEFER. Spread the virus to a new host: qusb2_phy_probe(). Specifically handle when our regulators might not be ready yet.

---

  drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-qusb2.c +0 -0
index 94afeac1a19e..26354618fd45 100644

drivers/phy/qualcomm/phy-qcom-qusb2.c static int qusb2_phy_probe(struct platform_device *pdev) · line 719

Quoted 10 lines
drivers/phy/qualcomm/phy-qcom-qusb2.c +3 -1
@@ -711,7 +711,9 @@ static int qusb2_phy_probe(struct platform_device *pdev)
 
  	ret = devm_regulator_bulk_get(dev, num, qphy->vregs);
  	if (ret) {
-		dev_err(dev, "failed to get regulator supplies\n");
+		if (ret != -EPROBE_DEFER)
+			dev_err(dev, "failed to get regulator supplies: %d\n",
+				ret);
  		return ret;
  	}
 

Thanks for the patch.

regards
Vivek

Reviewed-by on v1 1/2
#3 lore raw
In reply to Douglas Anderson

Hi Doug,

Quoted 16 lines · Douglas Anderson

The -EPROBE_DEFER virus demands special case code to avoid printing error messages when the error is only -EPROBE_DEFER. Spread the virus to a new host: qcom_qmp_phy_probe(). Specifically handle when our regulators might not be ready yet.

---

  drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/phy/qualcomm/phy-qcom-qmp.c +0 -0
index 6470c5d61d1c..a740daa58b31 100644

drivers/phy/qualcomm/phy-qcom-qmp.c static int qcom_qmp_phy_probe(struct platform_device *pdev) · line 1455

Quoted 10 lines
drivers/phy/qualcomm/phy-qcom-qmp.c +3 -1
@@ -1447,7 +1447,9 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
 
  	ret = qcom_qmp_phy_vreg_init(dev);
  	if (ret) {
-		dev_err(dev, "failed to get regulator supplies\n");
+		if (ret != -EPROBE_DEFER)
+			dev_err(dev, "failed to get regulator supplies: %d\n",
+				ret);
  		return ret;
  	}
 

Thanks for the patch. Looks good to me.

regards
Vivek

#4 lore raw
In reply to Douglas Anderson

Kishon,

Quoted 10 lines · Douglas Anderson

The -EPROBE_DEFER virus demands special case code to avoid printing error messages when the error is only -EPROBE_DEFER. Spread the virus to a new host: qcom_qmp_phy_probe(). Specifically handle when our regulators might not be ready yet.

---

 drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

I'm curious what you think of this patch and the next one. Is it something you'd apply or are you not interested? Either way is fine (it's just log spam) but I thought I'd check. Thanks! :)

-Doug