Skip to contentSkip to conversation

ARM: dts: imx28-tx28: Fix alias DTC warnings

PATCH New Fabio Estevam 2 participants 3 messages May 7, 2018 – May 15, 2018

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx28-tx28: Fix alias DTC warnings

From: Fabio Estevam <[email protected]>

Remove underscore from alias entries to fix the following DTC warnings with W=1:

arch/arm/boot/dts/imx28-tx28.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Cc Lothar Wa?mann <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx28-tx28.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/imx28-tx28.dts +6 -6
index e4f19f9b..a5d6c97 100644
@@ -56,11 +56,11 @@
 		ds1339 = &ds1339;
 		gpio5 = &gpio5;
 		lcdif = &lcdif;
-		lcdif_23bit_pins = &tx28_lcdif_23bit_pins;
-		lcdif_24bit_pins = &lcdif_24bit_pins_a;
-		reg_can_xcvr = &reg_can_xcvr;
-		spi_gpio = &spi_gpio;
-		spi_mxs = &ssp3;
+		lcdif-23bit-pins = &tx28_lcdif_23bit_pins;
+		lcdif-24bit-pins = &lcdif_24bit_pins_a;
+		reg-can-xcvr = &reg_can_xcvr;
+		spigpio = &spi_gpio;
+		spi-mxs = &ssp3;
 		stk5led = &user_led;
 		usbotg = &usb0;
 	};

@@ -220,7 +220,7 @@
 		linux,no-autorepeat;
 	};
 
-	spi_gpio: spi-gpio {
+	spi_gpio: spi {
 		compatible = "spi-gpio";
 		#address-cells = <1>;
 		#size-cells = <0>;
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ARM: dts: imx28-tx28: Fix alias DTC warnings

Quoted 35 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Remove underscore from alias entries to fix the following DTC warnings with W=1:

arch/arm/boot/dts/imx28-tx28.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Cc Lothar Wa?mann <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx28-tx28.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/imx28-tx28.dts +5 -5
index e4f19f9b..a5d6c97 100644
@@ -56,11 +56,11 @@
 		ds1339 = &ds1339;
 		gpio5 = &gpio5;
 		lcdif = &lcdif;
-		lcdif_23bit_pins = &tx28_lcdif_23bit_pins;
-		lcdif_24bit_pins = &lcdif_24bit_pins_a;
-		reg_can_xcvr = &reg_can_xcvr;
-		spi_gpio = &spi_gpio;
-		spi_mxs = &ssp3;
+		lcdif-23bit-pins = &tx28_lcdif_23bit_pins;
+		lcdif-24bit-pins = &lcdif_24bit_pins_a;
+		reg-can-xcvr = &reg_can_xcvr;
+		spigpio = &spi_gpio;
+		spi-mxs = &ssp3;
 		stk5led = &user_led;
 		usbotg = &usb0;
 	};

arch/arm/boot/dts/imx28-tx28.dts line 223

Quoted 5 lines
arch/arm/boot/dts/imx28-tx28.dts +1 -1
@@ -220,7 +220,7 @@
 		linux,no-autorepeat;
 	};
 
-	spi_gpio: spi-gpio {
+	spi_gpio: spi {

Not sure why the node name needs to be changed here.

Shawn

Quoted 6 lines
arch/arm/boot/dts/imx28-tx28.dts +0 -0
 		compatible = "spi-gpio";
 		#address-cells = <1>;
 		#size-cells = <0>;
Signature · 1 line
2.7.4
author reviewer
#2 lore raw

PATCH 1/1 ARM: dts: imx28-tx28: Fix alias DTC warnings

Quoted 4 lines · Shawn Guo

arch/arm/boot/dts/imx28-tx28.dts line 223

Quoted 2 lines
arch/arm/boot/dts/imx28-tx28.dts +1 -1
-     spi_gpio: spi-gpio {
+     spi_gpio: spi {

Not sure why the node name needs to be changed here.

Yes, this is a different fix and should be part of a different patch.