Skip to contentSkip to conversation

edac: altera: Fix ARM64 warning

PATCH New thor.thayer at linux.intel.com 2 participants 2 messages May 14, 2018 – May 15, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 edac: altera: Fix ARM64 warning

From: Thor Thayer <[email protected]>

The kbuild test robot reported the following warning on altera_edac.c:

drivers//edac/altera_edac.c: In function 'ocram_free_mem':
drivers//edac/altera_edac.c:1410:42: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]

  gen_pool_free((struct gen_pool *)other, (u32)p, size);
                                           ^^^

After adding support for ARM64 architectures, the unsigned long parameter is 64bits and causes a build warning with arm64-allyesconfig Fix by casting to the correct size (unsigned long) instead of u32.

Fixes c3eea1942a16 ("EDAC, altera: Add Altera L2 cache and OCRAM support")
---
 drivers/edac/altera_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/altera_edac.c +1 -1
index 5672f6718262..c5104ea7e1fb 100644
@@ -1415,7 +1415,7 @@ static void *ocram_alloc_mem(size_t size, void **other)
 
 static void ocram_free_mem(void *p, size_t size, void *other)
 {
-	gen_pool_free((struct gen_pool *)other, (u32)p, size);
+	gen_pool_free((struct gen_pool *)other, (unsigned long)p, size);
 }
 
 static const struct edac_device_prv_data ocramecc_data = {
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

PATCH 1/1 edac: altera: Fix ARM64 warning

Quoted 13 lines · thor.thayer at linux.intel.com

From: Thor Thayer <[email protected]>

The kbuild test robot reported the following warning on altera_edac.c:

drivers//edac/altera_edac.c: In function 'ocram_free_mem':
drivers//edac/altera_edac.c:1410:42: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]

  gen_pool_free((struct gen_pool *)other, (u32)p, size);
                                           ^^^

After adding support for ARM64 architectures, the unsigned long parameter is 64bits and causes a build warning with arm64-allyesconfig Fix by casting to the correct size (unsigned long) instead of u32.

Quoted 6 lines
Fixes c3eea1942a16 ("EDAC, altera: Add Altera L2 cache and OCRAM support")
---
 drivers/edac/altera_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Signature · 4 lines
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.