Skip to contentSkip to conversation

thunderbolt: Fix for v4.17-rc6

PATCH New Mika Westerberg 1 participant 2 messages May 15, 2018 Thunderbolt driver

lore
Share & tools
lore
#0 lore raw

cover thunderbolt: Fix for v4.17-rc6

Hi Greg,

There is one fix to make preboot ACL handling show NULL entries correctly in sysfs.

The patch is also included in case you want to apply it directly instead of pulling the signed tag.

The following changes since commit 75bc37fefc4471e718ba8e651aa74673d4e0a9eb:

Linux 4.17-rc4 (2018-05-06 16:57:38 -1000)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git tags/thunderbolt-fixes-for-v4.17-rc6

for you to fetch changes up to 50739cafb9401b9bf7642a5e1de88987b9d0c0fa:

thunderbolt: Handle NULL boot ACL entries properly (2018-05-07 15:14:16 +0300)

Mika Westerberg (1):
thunderbolt: Handle NULL boot ACL entries properly

 drivers/thunderbolt/icm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 thunderbolt: Handle NULL boot ACL entries properly

If the boot ACL entry is already NULL we should not fill in the upper two DWs with 0xfffffffff. Otherwise they are not shown as empty entries when the sysfs attribute is read.

Fixes 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
---
 drivers/thunderbolt/icm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/icm.c +1 -1
index 2d2ceda9aa26..500911f16498 100644
@@ -1255,7 +1255,7 @@ static int icm_ar_get_boot_acl(struct tb *tb, uuid_t *uuids, size_t nuuids)
 			/* Map empty entries to null UUID */
 			uuid[0] = 0;
 			uuid[1] = 0;
-		} else {
+		} else if (uuid[0] != 0 || uuid[1] != 0) {
 			/* Upper two DWs are always one's */
 			uuid[2] = 0xffffffff;
 			uuid[3] = 0xffffffff;
Signature · 1 line
2.17.0