NFS: Merge nfs41_free_stateid() with _nfs41_free_stateid()
Subsystems (2)
PATCH 1/1 NFS: Merge nfs41_free_stateid() with _nfs41_free_stateid()
From: Anna Schumaker <[email protected]>
Having these exist as two functions doesn't seem to add anything useful, and I think merging them together makes this easier to follow.
Signed-off-by Anna Schumaker <[email protected]>
--- fs/nfs/nfs4proc.c | 37 ++++++++++++++----------------------- 1 file changed, 14 insertions(+), 23 deletions(-)
fs/nfs/nfs4proc.c +14 -23
@@ -9299,7 +9299,17 @@ static const struct rpc_call_ops nfs41_free_stateid_ops = { .rpc_release = nfs41_free_stateid_release, }; -static struct rpc_task *_nfs41_free_stateid (struct nfs_server *server, +/** +* nfs41_free_stateid - perform a FREE_STATEID operation +* +* @server: server / transport on which to perform the operation +* @stateid: state ID to release +* @cred: credential +* @is_recovery: set to true if this call needs to be privileged +* +* Note: this function is always asynchronous. +*/ +static int nfs41_free_stateid (struct nfs_server *server,const nfs4_stateid *stateid,struct rpc_cred *cred,bool privileged)
@@ -9315,6 +9325,7 @@ static struct rpc_task *_nfs41_free_stateid(struct nfs_server *server, .flags = RPC_TASK_ASYNC, };struct nfs_free_stateid_data *data; +struct rpc_task *task;nfs4_state_protect (server->nfs_client,NFS_SP4_MACH_CRED_STATEID , &task_setup.rpc_client, &msg);
@@ -9322,7 +9333,7 @@ static struct rpc_task *_nfs41_free_stateid(struct nfs_server *server,dprintk ("NFS call free_stateid %p\n" , stateid); data =kmalloc (sizeof (*data),GFP_NOFS );if (!data) -return ERR_PTR (-ENOMEM ); +return -ENOMEM ; data->server = server;nfs4_stateid_copy (&data->args.stateid, stateid);
@@ -9331,27 +9342,7 @@ static struct rpc_task *_nfs41_free_stateid(struct nfs_server *server, msg.rpc_argp = &data->args; msg.rpc_resp = &data->res;nfs4_init_sequence (&data->args.seq_args, &data->res.seq_res,1 , privileged); -return rpc_run_task (&task_setup); -} - -/** -* nfs41_free_stateid - perform a FREE_STATEID operation -* -* @server: server / transport on which to perform the operation -* @stateid: state ID to release -* @cred: credential -* @is_recovery: set to true if this call needs to be privileged -* -* Note: this function is always asynchronous. -*/ -static int nfs41_free_stateid (struct nfs_server *server, -const nfs4_stateid *stateid, -struct rpc_cred *cred, -bool is_recovery) -{ -struct rpc_task *task; - - task =_nfs41_free_stateid (server, stateid, cred, is_recovery); + task =rpc_run_task (&task_setup);if (IS_ERR (task))return PTR_ERR (task);rpc_put_task (task);
Signature · 1 line
2.17.0