drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.
Subsystems (2)
PATCH 1/1 drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.
Normally this is called on a modeset, but the call is missing when we inherit the mode from the BIOS, so make sure it's called somewhere in hardware readout.
Changes since v1:
- Unconditionally call intel_opregion_notify_encoder. (Ville)
--- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_display.c +3 -0
@@ -15176,6 +15176,9 @@ static void intel_sanitize_encoder(struct intel_encoder *encoder) connector->base.dpms =DRM_MODE_DPMS_OFF ; connector->base.encoder =NULL ; } + +/* notify opregion of the sanitized encoder state */ +intel_opregion_notify_encoder (encoder, connector && has_active_crtc); }void i915_redisable_vga_power_on (struct drm_i915_private *dev_priv)
Signature · 6 lines
2.17.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.
== Series Details ==
== Series Details ==
Series: drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.
URL : https://patchwork.freedesktop.org/series/43243/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4191 -> Patchwork_9012 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9012 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9012, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43243/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9012:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: PASS -> SKIP
igt@kms_force_connector_basic@force-edid:
fi-snb-2520m: SKIP -> PASS +3== Known issues ==
Here are the changes found in Patchwork_9012 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_chamelium@hdmi-hpd-fast:
fi-kbl-7500u: SKIP -> FAIL (fdo#102672, fdo#103841)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106235)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: DMESG-WARN (fdo#106248) -> PASS
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: FAIL (fdo#102575) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-hsw-4770: FAIL (fdo#100368) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
fi-glk-j4005: DMESG-WARN (fdo#106235) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106235 https://bugs.freedesktop.org/show_bug.cgi?id=106235
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
== Participating hosts (42 -> 37) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4191 -> Patchwork_9012
CI_DRM_4191: 70daebf1a83c2ed6eff118d2a2806086c0c89027 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4484: b7432bf309d5d5a6e07e8a0d8b522302fb0b4502 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9012: be7fdd60410068da8816294b9d91385e4ab165c5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4484: 62ef6b0db8967e7021fd3e0b57d03ff164b984fe @ git://anongit.freedesktop.org/piglit
== Linux commits ==
be7fdd604100 drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9012/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 18 lines · Maarten Lankhorst
Normally this is called on a modeset, but the call is missing when we inherit the mode from the BIOS, so make sure it's called somewhere in hardware readout.
Changes since v1:
- Unconditionally callintel_opregion_notify_encoder. (Ville)Signed-off-by Maarten Lankhorst <[email protected]>Cc Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/i915/intel_display.c +0
-0
drivers/gpu/drm/i915/intel_display.c static void intel_sanitize_encoder(struct intel_encoder *encoder) · line 15181
Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +3
-0@@ -15176,6 +15176,9 @@ static void intel_sanitize_encoder(struct intel_encoder *encoder) connector->base.dpms =DRM_MODE_DPMS_OFF ; connector->base.encoder =NULL ; } + +/* notify opregion of the sanitized encoder state */ +intel_opregion_notify_encoder (encoder, connector && has_active_crtc);
Seems reasonable. The only minor nit is that we call this before the encoder hooks in the normal modeset path, here we call it after the hooks. Not sure it really matters though, so
Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c +0
-0}void i915_redisable_vga_power_on (struct drm_i915_private *dev_priv)Signature · 1 line
2.17.0
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/i915: Call intel_opregion_notify_encoder in intel_sanitize_encoder, v2.
URL : https://patchwork.freedesktop.org/series/43243/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4191_full -> Patchwork_9012_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9012_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9012_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/43243/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9012_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-vebox:
shard-kbl: PASS -> SKIP
igt@kms_concurrent@pipe-b:
shard-snb: PASS -> SKIP +1
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_9012_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359)
igt@gem_eio@in-flight-internal-10ms:
shard-glk: PASS -> DMESG-WARN (fdo#106523)
shard-apl: PASS -> DMESG-WARN (fdo#106523) +1
igt@gem_eio@wait-wedge-1us:
shard-hsw: PASS -> DMESG-WARN (fdo#106523)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_flip@2x-plain-flip-fb-recreate:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_flip@blocking-wf_vblank:
shard-glk: PASS -> FAIL (fdo#103928)
igt@kms_flip@dpms-vs-vblank-race:
shard-kbl: PASS -> FAIL (fdo#103060)
igt@kms_flip@modeset-vs-vblank-race:
shard-hsw: PASS -> FAIL (fdo#103060) +1
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-hsw: PASS -> FAIL (fdo#103928)
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: PASS -> FAIL (fdo#104724)
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103822)
igt@sw_sync@alloc_fence_invalid_timeline:
shard-apl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +9
==== Possible fixes ====
igt@gem_eio@in-flight-10ms:
shard-glk: DMESG-WARN (fdo#106523) -> PASS
igt@gem_eio@in-flight-contexts-1us:
shard-apl: DMESG-WARN (fdo#106523) -> PASS +2
igt@gem_eio@in-flight-immediate:
shard-hsw: DMESG-WARN (fdo#106523) -> PASS
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
shard-glk: FAIL (fdo#105703) -> PASS
igt@kms_cursor_legacy@flip-vs-cursor-toggle:
shard-hsw: FAIL (fdo#102670) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: FAIL (fdo#102887) -> PASS
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-kbl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +1
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#106523 https://bugs.freedesktop.org/show_bug.cgi?id=106523
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4191 -> Patchwork_9012
CI_DRM_4191: 70daebf1a83c2ed6eff118d2a2806086c0c89027 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4484: b7432bf309d5d5a6e07e8a0d8b522302fb0b4502 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9012: be7fdd60410068da8816294b9d91385e4ab165c5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4484: 62ef6b0db8967e7021fd3e0b57d03ff164b984fe @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9012/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx