Skip to contentSkip to conversation

arm: kirkwood: openrd: Change environment location

PATCH New Stefan Roese 2 participants 3 messages May 17, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: kirkwood: openrd: Change environment location

With GCC 7.3 and the addition of device-tree to Kirkwood, the U-Boot image does not fit any more into its 0x60000 area. Let's move the environment so that U-Boot will fit also with the upcoming changes for Kirkwood (add DM support etc).

Cc Tom Rini <[email protected]>
Cc Chris Packham <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Clint Adams <[email protected]>
---
 include/configs/openrd.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/configs/openrd.h +2 -2
index dfdad56dcc..3fe0a32a55 100644
@@ -42,8 +42,8 @@
  * it has to be rounded to sector size
  */
 #define CONFIG_ENV_SIZE			0x20000	/* 128k */
-#define CONFIG_ENV_ADDR			0x60000
-#define CONFIG_ENV_OFFSET		0x60000	/* env starts here */
+#define CONFIG_ENV_ADDR			0x80000
+#define CONFIG_ENV_OFFSET		0x80000	/* env starts here */
 /*
  * Environment is right behind U-Boot in flash. Make sure U-Boot
  * doesn't grow into the environment area.
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 arm: kirkwood: openrd: Change environment location

Quoted 11 lines · Stefan Roese

With GCC 7.3 and the addition of device-tree to Kirkwood, the U-Boot image does not fit any more into its 0x60000 area. Let's move the environment so that U-Boot will fit also with the upcoming changes for Kirkwood (add DM support etc).

Cc Tom Rini <[email protected]>
Cc Chris Packham <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Clint Adams <[email protected]>

---

Do we need to worry about a migration path for old -> new?

Quoted 20 lines
  include/configs/openrd.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
include/configs/openrd.h +2 -3
index dfdad56dcc..3fe0a32a55 100644
@@ -42,8 +42,8 @@
   * it has to be rounded to sector size
   */
  #define CONFIG_ENV_SIZE                        0x20000 /* 128k */
-#define CONFIG_ENV_ADDR                        0x60000
-#define CONFIG_ENV_OFFSET              0x60000 /* env starts here */
+#define CONFIG_ENV_ADDR                        0x80000
+#define CONFIG_ENV_OFFSET              0x80000 /* env starts here */
  /*
   * Environment is right behind U-Boot in flash. Make sure U-Boot
   * doesn't grow into the environment area.
--

2.17.0

#2 lore raw

PATCH 1/1 arm: kirkwood: openrd: Change environment location

Quoted 14 lines · Chris Packham
Quoted 11 lines · Stefan Roese

With GCC 7.3 and the addition of device-tree to Kirkwood, the U-Boot image does not fit any more into its 0x60000 area. Let's move the environment so that U-Boot will fit also with the upcoming changes for Kirkwood (add DM support etc).

Cc Tom Rini <[email protected]>
Cc Chris Packham <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Clint Adams <[email protected]>

---

Quoted 3 lines

Do we need to worry about a migration path for old -> new?

Thats definitely not perfect - I agree. But I'm not the maintainer of this board (Albert is) and he or somebody else might speak up to object on this.

We could also decide to not apply this patch right now and wait until we really need it, since its most likely not needed with your PHYLIB patch now.

Thanks,
Stefan