xen/kbdif: Add string constants for raw pointer

From: Oleksandr Andrushchenko <[email protected]>

It is now not fully possible to control if and which virtual devices are created by the frontend, e.g. keyboard and pointer devices are always created and multi-touch device is created if the backend advertises multi-touch support. In some cases this behavior is not desirable and better control over the frontend's configuration is required.

Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created

Keep old behavior by default.

Signed-off-by Oleksandr Andrushchenko <[email protected]>

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

---
  xen/include/public/io/kbdif.h | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

xen/include/public/io/kbdif.h +12 -0

index daf4bc2063c9..23d1f70d5210 100644
@@ -51,6 +51,18 @@
   * corresponding entries in XenStore and puts 1 as the value of the entry.
   * If a feature is not supported then 0 must be set or feature entry omitted.
   *
+ * feature-disable-keyboard
+ *      Values:         <uint>
+ *
+ *      If there is no need to expose a virtual keyboard device by the
+ *      frontend then this must be set to 1.
+ *
+ * feature-disable-pointer
+ *      Values:         <uint>
+ *
+ *      If there is no need to expose a virtual pointer device by the
+ *      frontend then this must be set to 1.
+ *
   * feature-abs-pointer
   *      Values:         <uint>
   *

Hi, Juergen!

This patch should go into 4.11 as it is needed for a related Linux kernel patch and the risk is next to zero for Xen due to only adding some macros not in use on Xen side.

Could you please release ack this

and apply?

Quoted 7 lines · Oleksandr Andrushchenko

Hi, Juergen!

This patch should go into 4.11 as it is needed for a related Linux kernel patch and the risk is next to zero for Xen due to only adding some macros not in use on Xen side.

Could you please release ack this

Release-acked-by Juergen Gross <[email protected]>

Quoted 1 line

and apply?

This has to be done by a committer, which I'm not.

Juergen

Quoted 7 lines · Juergen Gross

Quoted 6 lines · Oleksandr Andrushchenko

Hi, Juergen!

This patch should go into 4.11 as it is needed for a related Linux kernel patch and the risk is next to zero for Xen due to only adding some macros not in use on Xen side.

Quoted 2 lines

Quoted 1 line

Could you please release ack this

Release-acked-by Juergen Gross <[email protected]>

Thank you

Quoted 2 lines

Quoted 1 line

and apply?

This has to be done by a committer, which I'm not.

Konrad, could you please apply?

Quoted 2 lines

Juergen

Thank you,
Oleksandr

Quoted 8 lines · Oleksandr Andrushchenko

Quoted 7 lines · Juergen Gross

Quoted 6 lines · Oleksandr Andrushchenko

Hi, Juergen!

This patch should go into 4.11 as it is needed for a related Linux kernel patch and the risk is next to zero for Xen due to only adding some macros not in use on Xen side.

Quoted 6 lines

Quoted 2 lines

Quoted 1 line

Could you please release ack this

Release-acked-by Juergen Gross <[email protected]>

Thank you

Quoted 2 lines

Quoted 1 line

and apply?

This has to be done by a committer, which I'm not.

Konrad, could you please apply?

Yes of course.

Quoted 3 lines

Quoted 1 line

Juergen

Thank you,
Oleksandr

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by Oleksandr Andrushchenko <[email protected]>

---
  xen/include/public/io/kbdif.h | 2 ++
  1 file changed, 2 insertions(+)

xen/include/public/io/kbdif.h +0 -0

index 3ce54e9a44c1..daf4bc2063c9 100644

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by Oleksandr Andrushchenko <[email protected]>

---
 xen/include/public/io/kbdif.h | 2 ++
 1 file changed, 2 insertions(+)

xen/include/public/io/kbdif.h +2 -0

index 3ce54e9a44c1..daf4bc2063c9 100644
@@ -178,8 +178,10 @@
 #define XENKBD_DRIVER_NAME             "vkbd"
 
 #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
+#define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
 #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"
 #define XENKBD_FIELD_REQ_ABS_POINTER   "request-abs-pointer"
+#define XENKBD_FIELD_REQ_RAW_POINTER   "request-raw-pointer"
 #define XENKBD_FIELD_REQ_MTOUCH        "request-multi-touch"
 #define XENKBD_FIELD_RING_GREF         "page-gref"
 #define XENKBD_FIELD_EVT_CHANNEL       "event-channel"

Signature · 1 line

2.17.0

Quoted 5 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Quoted 3 lines

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by Oleksandr Andrushchenko <[email protected]>

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

Thank you!

Quoted 11 lines

---
 xen/include/public/io/kbdif.h | 2 ++
 1 file changed, 2 insertions(+)

xen/include/public/io/kbdif.h +0 -0

index 3ce54e9a44c1..daf4bc2063c9 100644
@@ -178,8 +178,10 @@
 #define XENKBD_DRIVER_NAME             "vkbd"
 

Quoted 11 lines

xen/include/public/io/kbdif.h +2 -0

 #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
+#define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
 #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"
 #define XENKBD_FIELD_REQ_ABS_POINTER   "request-abs-pointer"
+#define XENKBD_FIELD_REQ_RAW_POINTER   "request-raw-pointer"
 #define XENKBD_FIELD_REQ_MTOUCH        "request-multi-touch"
 #define XENKBD_FIELD_RING_GREF         "page-gref"
 #define XENKBD_FIELD_EVT_CHANNEL       "event-channel"

Signature · 1 line

2.17.0

Quoted 6 lines · Konrad Rzeszutek Wilk

Quoted 5 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Quoted 6 lines

Quoted 3 lines

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by Oleksandr Andrushchenko <[email protected]>

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

Juergen, you OK with an release-ack?

Quoted 9 lines · Konrad Rzeszutek Wilk

Quoted 8 lines · Konrad Rzeszutek Wilk

Quoted 7 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Quoted 4 lines

Quoted 3 lines

Quoted 1 line

Signed-off-by Oleksandr Andrushchenko <[email protected]>

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

Juergen, you OK with an release-ack?

Yes:

Release-acked-by Juergen Gross <[email protected]>

Juergen

Quoted 15 lines · Juergen Gross

Quoted 14 lines · Konrad Rzeszutek Wilk

Quoted 13 lines · Konrad Rzeszutek Wilk

Quoted 10 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by: Oleksandr Andrushchenko
<[email protected]>

Quoted 5 lines

Quoted 2 lines

Quoted 1 line

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

Juergen, you OK with an release-ack?

Yes:

Release-acked-by Juergen Gross <[email protected]>

Is this ack for both patches or this one only?

I see Konrad has applied this patch, but
"[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer"
is still floating.

Quoted 15 lines · Oleksandr Andrushchenko

Quoted 14 lines · Juergen Gross

Quoted 13 lines · Konrad Rzeszutek Wilk

Quoted 12 lines · Konrad Rzeszutek Wilk

Quoted 10 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by: Oleksandr Andrushchenko
<[email protected]>

Quoted 6 lines

Quoted 5 lines

Quoted 2 lines

Quoted 1 line

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

Juergen, you OK with an release-ack?

Yes:

Release-acked-by Juergen Gross <[email protected]>

Is this ack for both patches or this one only?

It was meant for patch 1 only.

Quoted 4 lines

I see Konrad has applied this patch, but
"[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer"
is still floating.

In principle I'm fine with taking it for 4.11, but I think at this stage of the release there should be a formal request to include it.

Juergen

Quoted 16 lines · Juergen Gross

Quoted 15 lines · Oleksandr Andrushchenko

Quoted 14 lines · Juergen Gross

Quoted 13 lines · Konrad Rzeszutek Wilk

Quoted 12 lines · Konrad Rzeszutek Wilk

Quoted 10 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by: Oleksandr Andrushchenko
<[email protected]>

Quoted 7 lines

Quoted 6 lines

Quoted 5 lines

Quoted 2 lines

Quoted 1 line

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

Juergen, you OK with an release-ack?

Yes:

Release-acked-by Juergen Gross <[email protected]>

Is this ack for both patches or this one only?

It was meant for patch 1 only.

Clear

Quoted 6 lines

Quoted 4 lines

I see Konrad has applied this patch, but
"[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer"
is still floating.

In principle I'm fine with taking it for 4.11, but I think at this stage of the release there should be a formal request to include it.

...and the request should come from Konrad?
Or who else may request that?

And, as I have r-b's from Konrad for both patches, will it be ok if we apply the corresponding changes to the kernel now, so my change to xen-kbdfront is unblocked?

Quoted 25 lines · Oleksandr Andrushchenko

Quoted 16 lines · Juergen Gross

Quoted 15 lines · Oleksandr Andrushchenko

Quoted 14 lines · Juergen Gross

Quoted 13 lines · Konrad Rzeszutek Wilk

Quoted 12 lines · Konrad Rzeszutek Wilk

Quoted 10 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by: Oleksandr Andrushchenko
<[email protected]>

Quoted 7 lines

Quoted 6 lines

Quoted 5 lines

Quoted 2 lines

Quoted 1 line

Reviewed-by Konrad Rzeszutek Wilk <[email protected]>

Juergen, you OK with an release-ack?

Yes:

Release-acked-by Juergen Gross <[email protected]>

Is this ack for both patches or this one only?

It was meant for patch 1 only.

Clear

Quoted 8 lines

Quoted 6 lines

Quoted 4 lines

I see Konrad has applied this patch, but
"[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer"
is still floating.

In principle I'm fine with taking it for 4.11, but I think at this stage of the release there should be a formal request to include it.

...and the request should come from Konrad?
Or who else may request that?

Normally the sender of the patch would make this request below the --- of the commit message, e.g.:
---
This patch should go into 4.11 as it is needed for a related Linux kernel patch and the risk is next to zero for Xen due to only adding some macros not in use on Xen side.

The request can be made by anyone, of course, e.g. by replying to the patch mail and including the release manager as a recipient.

Quoted 3 lines

And, as I have r-b's from Konrad for both patches, will it be ok if we apply the corresponding changes to the kernel now, so my change to xen-kbdfront is unblocked?

No, please don't do that.

Juergen