net: NET_VENDOR_MICROSEMI should default ot N
Subsystems (3)
PATCH 1/1 net: NET_VENDOR_MICROSEMI should default ot N
Other ethernet drivers default to N. There is no reason for Microsemi to default to y. I believe Linus has set the bar at a feature that cures cancer can be enabled by default. [1]
[1] https://lkml.org/lkml/2010/3/2/366
--- drivers/net/ethernet/mscc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mscc/Kconfig +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0 OR MIT) config NET_VENDOR_MICROSEMI bool "Microsemi devices" - default y + default n help If you have a network (Ethernet) card belonging to this class, say Y.
Signature · 1 line
2.11.0
Quoted 16 lines · David Ahern
Other ethernet drivers default to N. There is no reason for Microsemi to default to y. I believe Linus has set the bar at a feature that cures cancer can be enabled by default. [1]
[1] https://lkml.org/lkml/2010/3/2/366
Signed-off-by David Ahern <[email protected]>--- drivers/net/ethernet/mscc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/mscc/Kconfig +0
-0
drivers/net/ethernet/mscc/Kconfig line 4
Quoted 5 lines
drivers/net/ethernet/mscc/Kconfig +1
-1@@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0 OR MIT) config NET_VENDOR_MICROSEMI bool "Microsemi devices" - default y + default n
You know that N is the default default? :-)
[...]
MBR, Sergei
David Miller
maintainerFrom: David Ahern <[email protected]>
Date: Thu, 17 May 2018 08:43:30 -0700
Quoted 7 lines
Other ethernet drivers default to N. There is no reason for Microsemi to default to y. I believe Linus has set the bar at a feature that cures cancer can be enabled by default. [1]
[1] https://lkml.org/lkml/2010/3/2/366
Signed-off-by David Ahern <[email protected]>
For "drivers" yes, those should default to N. But for vendor guards like this, they should default to Y.