pylibfdt: Add missing CC and LD to Makefile
PATCH 1/1 pylibfdt: Add missing CC and LD to Makefile
Add missing CC and LDSHARED variables to the Makefile to pass the correct C compiler and linker path to the build of _libfdt.so .
---
Note: This fixes the long standing issue when building U-Boot with
OE for qemux86 or qemux86_64, where the build will try to use the host compiler, which OE will block and thus the build will crash on missing compiler/linker binary. With this patch, the OE will correctly pass in the compiler/linker generated during the build, just like it does for all the other tools.
--- scripts/dtc/pylibfdt/Makefile | 1 + 1 file changed, 1 insertion(+)
scripts/dtc/pylibfdt/Makefile +1 -0
@@ -15,6 +15,7 @@ PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \ quiet_cmd_pymod = PYMOD $@ cmd_pymod = unset CC; unset CROSS_COMPILE; unset CFLAGS;\ + CC="$(HOSTCC)" LDSHARED="$(HOSTCC) -shared " \ LDFLAGS="$(HOSTLDFLAGS)" \ VERSION="u-boot-$(UBOOTVERSION)" \ CPPFLAGS="$(HOSTCFLAGS) -I$(LIBFDT_srcdir)" OBJDIR=$(obj) \
Signature · 1 line
2.16.2
PATCH 1/1 pylibfdt: Add missing CC and LD to Makefile
Quoted 15 lines · Marek Vasut
Add missing CC and LDSHARED variables to the
Makefileto pass the correct C compiler and linker path to the build of _libfdt.so .Signed-off-by Marek Vasut <[email protected]>Cc Tom Rini <[email protected]>Cc Masahiro Yamada <[email protected]>Cc Simon Glass <[email protected]>---
Note: This fixes the long standing issue when building U-Boot with
OE for qemux86 orqemux86_64, where the build will try to use the host compiler, which OE will block and thus the build will crash on missing compiler/linker binary. With this patch, the OE will correctly pass in the compiler/linker generated during the build, just like it does for all the other tools.
Quoted 3 lines
--- scripts/dtc/pylibfdt/Makefile | 1 + 1 file changed, 1 insertion(+)
scripts/dtc/pylibfdt/Makefile PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \ · line 17
Quoted 9 lines
scripts/dtc/pylibfdt/Makefile +0
-0@@ -15,6 +15,7 @@ PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \ quiet_cmd_pymod = PYMOD $@ cmd_pymod = unset CC; unset CROSS_COMPILE; unset CFLAGS;\
Please can you remove the 'unset CC'? It does not seem necessary since you set it later:
Quoted 7 lines
scripts/dtc/pylibfdt/Makefile +1
-1+ CC="$(HOSTCC)" LDSHARED="$(HOSTCC) -shared " \ LDFLAGS="$(HOSTLDFLAGS)" \ VERSION="u-boot-$(UBOOTVERSION)" \ CPPFLAGS="$(HOSTCFLAGS) -I$(LIBFDT_srcdir)" OBJDIR=$(obj) \ --2.16.2
PATCH 1/1 pylibfdt: Add missing CC and LD to Makefile
Quoted 29 lines · Simon Glass
Quoted 15 lines · Marek Vasut
Add missing CC and LDSHARED variables to the
Makefileto pass the correct C compiler and linker path to the build of _libfdt.so .Signed-off-by Marek Vasut <[email protected]>Cc Tom Rini <[email protected]>Cc Masahiro Yamada <[email protected]>Cc Simon Glass <[email protected]>---
Note: This fixes the long standing issue when building U-Boot with
OE for qemux86 orqemux86_64, where the build will try to use the host compiler, which OE will block and thus the build will crash on missing compiler/linker binary. With this patch, the OE will correctly pass in the compiler/linker generated during the build, just like it does for all the other tools.Quoted 3 lines
--- scripts/dtc/pylibfdt/Makefile | 1 + 1 file changed, 1 insertion(+)Reviewed-by Simon Glass <[email protected]>Quoted 7 lines
scripts/dtc/pylibfdt/Makefile +0
-0@@ -15,6 +15,7 @@ PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \
Quoted 5 lines
scripts/dtc/pylibfdt/Makefile PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \ · line 17
Quoted 2 lines
scripts/dtc/pylibfdt/Makefile +0
-0quiet_cmd_pymod = PYMOD $@ cmd_pymod = unset CC; unset CROSS_COMPILE; unset CFLAGS;\Please can you remove the 'unset CC'? It does not seem necessary since you set it later:
Yeah.
Quoted 7 lines
Quoted 7 lines
scripts/dtc/pylibfdt/Makefile +1
-1+ CC="$(HOSTCC)" LDSHARED="$(HOSTCC) -shared " \ LDFLAGS="$(HOSTLDFLAGS)" \ VERSION="u-boot-$(UBOOTVERSION)" \ CPPFLAGS="$(HOSTCFLAGS) -I$(LIBFDT_srcdir)" OBJDIR=$(obj) \ --2.16.2
Signature · 2 lines
Best regards, Marek Vasut