Skip to contentSkip to conversation

ARM: davinci: board-da850-evm: fix WP pin polarity for MMC/SD

PATCH New Adam Ford 2 participants 2 messages May 18, 2018 – Jun 26, 2018

Subsystems (3)
Arm (32-bit) Arm sub-architectures TI DaVinci machine support
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ARM: davinci: board-da850-evm: fix WP pin polarity for MMC/SD

When booting from MMC/SD in rw mode, the system crashes because the write protect pin should be active high and not active low. This patch fixes the polarity of the WP pin.

Fixes 67c6b6ff221f ("ARM: davinci: board-da850-evm: fix GPIO

lookup for MMC/SD")

Signed-off-by Adam Ford <[email protected]>
arch/arm/mach-davinci/board-da850-evm.c +1 -1
index e22fb40e34bc..6d5beb11bd96 100644
@@ -774,7 +774,7 @@ static struct gpiod_lookup_table mmc_gpios_table = {
 		GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_CD_PIN, "cd",
 			    GPIO_ACTIVE_LOW),
 		GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_WP_PIN, "wp",
-			    GPIO_ACTIVE_LOW),
+			    GPIO_ACTIVE_HIGH),
 	},
 };
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 ARM: davinci: board-da850-evm: fix WP pin polarity for MMC/SD

Quoted 1 line · Adam Ford

When booting from MMC/SD in rw mode, the system crashes because

... in rw mode on DA850 EVM, ..

Quoted 5 lines

the write protect pin should be active high and not active low. This patch fixes the polarity of the WP pin.

Fixes 67c6b6ff221f ("ARM: davinci: board-da850-evm: fix GPIO

lookup for MMC/SD")

Fixes bdf0e8364fd3 ("ARM: davinci: da850-evm: use gpio descriptor for mmc pins")

is more appropriate since thats where the bug was actually introduced and thats how far back you want the patch backported.

Quoted 2 lines
Signed-off-by Adam Ford <[email protected]>

With these changes, applied to fixes for v4.18.

Thanks,
Sekhar