Skip to contentSkip to conversation

pylibfdt: Add missing CC and LD to Makefile

PATCH New Marek Vasut 3 participants 3 messages May 18, 2018 – May 24, 2018 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pylibfdt: Add missing CC and LD to Makefile

Add missing CC and LDSHARED variables to the Makefile to pass the correct C compiler and linker path to the build of _libfdt.so .

Cc Tom Rini <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Simon Glass <[email protected]>

---
Note: This fixes the long standing issue when building U-Boot with
OE for qemux86 or qemux86_64, where the build will try to use the host compiler, which OE will block and thus the build will crash on missing compiler/linker binary. With this patch, the OE will correctly pass in the compiler/linker generated during the build, just like it does for all the other tools.
V2: Drop unset CC

---
 scripts/dtc/pylibfdt/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/dtc/pylibfdt/Makefile +2 -1
index 01d5e0ffe3..c769d7db06 100644
@@ -14,7 +14,8 @@ PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \
 		$(obj)/libfdt.i
 
 quiet_cmd_pymod = PYMOD   $@
-      cmd_pymod = unset CC; unset CROSS_COMPILE; unset CFLAGS;\
+      cmd_pymod = unset CROSS_COMPILE; unset CFLAGS; \
+		CC="$(HOSTCC)" LDSHARED="$(HOSTCC) -shared " \
 		LDFLAGS="$(HOSTLDFLAGS)" \
 		VERSION="u-boot-$(UBOOTVERSION)" \
 		CPPFLAGS="$(HOSTCFLAGS) -I$(LIBFDT_srcdir)" OBJDIR=$(obj) \
Signature · 1 line
2.16.2
#1 lore raw

PATCH v2 1/1 pylibfdt: Add missing CC and LD to Makefile

Hi Marek

2018-05-18 16:56 GMT+09:00 Marek Vasut <[email protected]>:

Quoted 24 lines

Add missing CC and LDSHARED variables to the Makefile to pass the correct C compiler and linker path to the build of _libfdt.so .

Cc Tom Rini <[email protected]>
Cc Masahiro Yamada <[email protected]>
Cc Simon Glass <[email protected]>

---
Note: This fixes the long standing issue when building U-Boot with
OE for qemux86 or qemux86_64, where the build will try to use the host compiler, which OE will block and thus the build will crash on missing compiler/linker binary. With this patch, the OE will correctly pass in the compiler/linker generated during the build, just like it does for all the other tools.
V2: Drop unset CC

---
 scripts/dtc/pylibfdt/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/dtc/pylibfdt/Makefile +0 -0
index 01d5e0ffe3..c769d7db06 100644

scripts/dtc/pylibfdt/Makefile PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \ · line 18

Quoted 6 lines
scripts/dtc/pylibfdt/Makefile +2 -1
@@ -14,7 +14,8 @@ PYLIBFDT_srcs = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_SRCS)) \
                $(obj)/libfdt.i
 
 quiet_cmd_pymod = PYMOD   $@
-      cmd_pymod = unset CC; unset CROSS_COMPILE; unset CFLAGS;\
+      cmd_pymod = unset CROSS_COMPILE; unset CFLAGS; \
+               CC="$(HOSTCC)" LDSHARED="$(HOSTCC) -shared " \

Do you need a space between -shared and the double-quote?

Anyway,

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw

PATCH v2 1/1 pylibfdt: Add missing CC and LD to Makefile

In reply to Marek Vasut
Quoted 8 lines · Marek Vasut

Add missing CC and LDSHARED variables to the Makefile to pass the correct C compiler and linker path to the build of _libfdt.so .

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180524/05d2a5ef/attachment.sig>