Skip to contentSkip to conversation

drm/exynos: fimc: signedness bug in fimc_setup_clocks()

PATCH Applied Dan Carpenter 2 participants 2 messages May 18, 2018 – May 23, 2018

Subsystems (4)
DRM drivers Kernel janitors Arm Samsung Exynos DRM drivers for Exynos
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/exynos: fimc: signedness bug in fimc_setup_clocks()

"id" needs to be signed for the error handling to work.

Fixes 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/exynos/exynos_drm_fimc.c +1 -1
index 4dfbfc7f3b84..5ce84025d1cb 100644
@@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx)
 
 int exynos_drm_check_fimc_device(struct device *dev)
 {
-	unsigned int id = of_alias_get_id(dev->of_node, "fimc");
+	int id = of_alias_get_id(dev->of_node, "fimc");
 
 	if (id >= 0 && (BIT(id) & fimc_mask))
 		return 0;
maintainer Applied
#1 lore raw

2018년 05월 18일 17:04에 Dan Carpenter 이(가) 쓴 글:

Quoted 1 line

"id" needs to be signed for the error handling to work.

Applied to exynos-drm-fixes-v4.18-rc1.

Thanks,
Inki Dae

Quoted 24 lines
Fixes 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/exynos/exynos_drm_fimc.c +1 -2
index 4dfbfc7f3b84..5ce84025d1cb 100644
@@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx)
 
 int exynos_drm_check_fimc_device(struct device *dev)
 {
-	unsigned int id = of_alias_get_id(dev->of_node, "fimc");
+	int id = of_alias_get_id(dev->of_node, "fimc");
 
 	if (id >= 0 && (BIT(id) & fimc_mask))
 		return 0;
--

To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html