Skip to contentSkip to conversation

usb: usbtmc: Add ioctls for trigger, EOM bit and TermChar

PATCH New Greg Kroah-Hartman 1 participant 1 message May 18, 2018 USB

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 4/12 usb: usbtmc: Add ioctls for trigger, EOM bit and TermChar

Quoted 25 lines · On Fri, May 18, 2018 at 12:08:16PM +0000, [email protected] wrote:

Zitat von Greg KH <[email protected]>:

Quoted 22 lines · Guido Kiener
Quoted 21 lines

- add USBTMC488_IOCTL_TRIGGER to send TRIGGER Bulk-OUT header according to Subclass USB488 Specification

The usbtmc trigger command is equivalent to the IEEE 488 GET (Group Execute Trigger) action. While the "*TRG" command can be sent as data to perform the same operation, in some situations an instrument will be busy and unable to process the data immediately in which case the USBTMC488_IOCTL_TRIGGER can be used to trigger the instrument with lower latency.

- add USBTMC_IOCTL_EOM_ENABLE to specify EOM bit for next write() call. Sets Bit 0 of field 'bmTransferAttributes' of DEV_DEP_MSG_OUT Bulk-OUT Header.

Allows fine grained control over end of message handling on a per file descriptor basis.

- add USBTMC_IOCTL_CONFIG_TERMCHAR to control TermChar handling for next read(). Controls field 'TermChar' and Bit 1 of field 'bmTransferAttributes' of REQUEST_DEV_DEP_MSG_IN BULK-OUT header.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Allows enabling/disabling of terminating a read on reception of term_char individually for each read request.

Why isn't this 3 patches? Please only do "one thing per patch".

I just thought it is clearly arranged. Please let me know when you want to see a breakup of other patches as well.

I only got this far in the patch series and I stopped. As you know this has to be broken up, please do that and we can iterate from there.

Worse case, I take the first few patches and you redo the later ones, that's a very common process.

Quoted 2 lines

However I would be happy when I could save some extra work here. In the middle of next week I start my holiday.

No rush on my end, there's no deadlines in kernel development, send them when you have them ready :)

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html