Skip to contentSkip to conversation

USB: serial: ftdi_sio: fix IXON/IXOFF mixup

PATCH New Johan Hovold 1 participant 1 message May 18, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 USB: serial: ftdi_sio: fix IXON/IXOFF mixup

Quoted 6 lines · Greg Kroah-Hartman
Quoted 3 lines · Johan Hovold

Since forever this driver has had IXON and IXOFF mixed up, and has used the latter rather than the former to enable hardware-assisted software flow control on output.

Ugh, that's a huge sign that no one actually uses IXON/IXOFF anymore :(

Could be that some applications set both IXON and IXOFF "just to be safe"; that appears to be the case with minicom at least.

Quoted 2 lines

Anyway, thanks for fixing this up, should also probably be backported to the stable kernels.

I considered that, but since its a change in behaviour I figured it was best that anyone affected hits this with a major (minor?) kernel version update (rather than a stable update). But I'll add a stable tag if you think it's warranted?

Quoted 1 line

Thanks for the review.

Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html