usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ
Greg Kroah-Hartman
maintainerPATCH 7/12 usb: usbtmc: Add ioctl USBTMC488_IOCTL_WAIT_SRQ
Quoted 17 lines · On Fri, May 18, 2018 at 03:02:10PM +0000, [email protected] wrote:
Zitat von Greg KH <[email protected]>:
Quoted 13 lines · Guido Kiener
Review static int usbtmc_probe(struct usb_interface *intf, · line 2482
Quoted 10 lines
(quoted diff) +2
-2@@ -2420,8 +2476,8 @@ static int usbtmc_probe(struct usb_interface *intf, retcode = usb_register_dev(intf, &usbtmc_class); if (retcode) { - dev_err(&intf->dev, "Not able to get a minor" - " (base %u, slice default): %d\n", USBTMC_MINOR_BASE, + dev_err(&intf->dev, "Not able to get a minor (base %u, slice default): %d\n", + USBTMC_MINOR_BASE, retcode);Nice change, but totally not relevant for this specific patch :(
Quoted 1 line
Extra patch or just omit?
Extra patch please :)
Quoted 2 lines
I thought kernel message must not be broken due to rule 80 characters per line.
You are correct, just don't try to "sneak" it into a patch that does something totally different.
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html