Skip to contentSkip to conversation

travis-ci: run gcc-7 on linux-gcc jobs

PATCH Superseded Nguyễn Thái Ngọc Duy 3 participants 4 messages May 13, 2018 – May 21, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 travis-ci: run gcc-7 on linux-gcc jobs

Switch from gcc-4.8 to gcc-7. Newer compilers come with more warning checks (usually in -Wextra). Since -Wextra is enabled in developer mode (which is also enabled in travis), this lets travis report more warnings before other people do it.

---
 .travis.yml        | 3 +++
 ci/lib-travisci.sh | 3 +++
 2 files changed, 6 insertions(+)
.travis.yml +3 -0
index 5f5ee4f3bd..a77f5f5bd5 100644
@@ -16,10 +16,13 @@ compiler:
 
 addons:
   apt:
+    sources:
+    - ubuntu-toolchain-r-test
     packages:
     - language-pack-is
     - git-svn
     - apache2
+    - gcc-7
 
 matrix:
   include:
ci/lib-travisci.sh +3 -0
index 109ef280da..ef2848fd45 100755
@@ -99,6 +99,9 @@ export DEFAULT_TEST_TARGET=prove
 export GIT_PROVE_OPTS="--timer --jobs 3 --state=failed,slow,save"
 export GIT_TEST_OPTS="--verbose-log -x"
 export GIT_TEST_CLONE_2GB=YesPlease
+if [ "$jobname" = linux-gcc ]; then
+	export CC=gcc-7
+fi
 
 case "$jobname" in
 linux-clang|linux-gcc)
Signature · 1 line
2.17.0.705.g3525833791
#1 lore raw

Am 13.05.2018 um 11:17 schrieb Nguyễn Thái Ngọc Duy:

Quoted 16 lines

Switch from gcc-4.8 to gcc-7. Newer compilers come with more warning checks (usually in -Wextra). Since -Wextra is enabled in developer mode (which is also enabled in travis), this lets travis report more warnings before other people do it.

---
 .travis.yml        | 3 +++
 ci/lib-travisci.sh | 3 +++
 2 files changed, 6 insertions(+)
.travis.yml +0 -0
index 5f5ee4f3bd..a77f5f5bd5 100644

.travis.yml compiler: · line 25

Quoted 10 lines
.travis.yml +3 -0
@@ -16,10 +16,13 @@ compiler:
 
 addons:
   apt:
+    sources:
+    - ubuntu-toolchain-r-test
     packages:
     - language-pack-is
     - git-svn
     - apache2
+    - gcc-7

You could also use gcc-8 here as that is already present according to [1].

[1]:
https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test/+packages

Quoted 17 lines
.travis.yml +0 -0
 matrix:
   include:
ci/lib-travisci.sh +3 -0
index 109ef280da..ef2848fd45 100755
@@ -99,6 +99,9 @@ export DEFAULT_TEST_TARGET=prove
 export GIT_PROVE_OPTS="--timer --jobs 3 --state=failed,slow,save"
 export GIT_TEST_OPTS="--verbose-log -x"
 export GIT_TEST_CLONE_2GB=YesPlease
+if [ "$jobname" = linux-gcc ]; then
+	export CC=gcc-7
+fi
 
 case "$jobname" in
 linux-clang|linux-gcc)
#2 lore raw

PATCH v2 1/1 travis-ci: run gcc-8 on linux-gcc jobs

In reply to Nguyễn Thái Ngọc Duy

Switch from gcc-4.8 to gcc-8. Newer compilers come with more warning checks (usually in -Wextra). Since -Wextra is enabled in developer mode (which is also enabled in travis), this lets travis report more warnings before other people do it.

---
v2 switches from gcc-7 to gcc-8. I initially ignored gcc 8 because it was too new. But it built 'pu' ok and 8.1 was already out so the first wave of bugs should have been gone by now.

 .travis.yml        | 3 +++
 ci/lib-travisci.sh | 3 +++
 2 files changed, 6 insertions(+)
.travis.yml +3 -0
index 5f5ee4f3bd..4d4e26c9df 100644
@@ -16,10 +16,13 @@ compiler:
 
 addons:
   apt:
+    sources:
+    - ubuntu-toolchain-r-test
     packages:
     - language-pack-is
     - git-svn
     - apache2
+    - gcc-8
 
 matrix:
   include:
ci/lib-travisci.sh +3 -0
index 109ef280da..ceecc889ca 100755
@@ -99,6 +99,9 @@ export DEFAULT_TEST_TARGET=prove
 export GIT_PROVE_OPTS="--timer --jobs 3 --state=failed,slow,save"
 export GIT_TEST_OPTS="--verbose-log -x"
 export GIT_TEST_CLONE_2GB=YesPlease
+if [ "$jobname" = linux-gcc ]; then
+	export CC=gcc-8
+fi
 
 case "$jobname" in
 linux-clang|linux-gcc)
Signature · 1 line
2.17.0.705.g3525833791
#3 lore raw

Re: [PATCH v2] travis-ci: run gcc-8 on linux-gcc jobs

Quoted 3 lines · Nguyễn Thái Ngọc Duy

v2 switches from gcc-7 to gcc-8. I initially ignored gcc 8 because it was too new. But it built 'pu' ok and 8.1 was already out so the first wave of bugs should have been gone by now.

I also liked the choice to ignore v8 for the same reason, but if it is already mature (or maturing enough), let's use it.