Skip to contentSkip to conversation

ARM: dts: am3517-evm: Remove unnessary PMIC parameters

PATCH In review Adam Ford 2 participants 3 messages May 19, 2018 – Jul 3, 2018 Device tree bindings

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ARM: dts: am3517-evm: Remove unnessary PMIC parameters

The AM3517-EVM uses a TPS65023 PMIC. This is already defined
by: compatible = "ti,tps65023"

There doesn't seem to be a need to have each regulator in the PMIC with the 'compatible = "regulator-fixed"' since each regulator has a min and max setting.

Signed-off-by Adam Ford <[email protected]>
arch/arm/boot/dts/am3517-som.dtsi +0 -5
index a6d5ff73c163..7ff7cd135dca 100644
@@ -64,7 +64,6 @@
 		regulators {
 			vdd_core_reg: VDCDC1 {
 				regulator-name = "vdd_core";
-				compatible = "regulator-fixed";
 				regulator-always-on;
 				regulator-min-microvolt = <1200000>;
 				regulator-max-microvolt = <1200000>;

@@ -72,7 +71,6 @@
 
 			vdd_io_reg: VDCDC2 {
 				regulator-name = "vdd_io";
-				compatible = "regulator-fixed";
 				regulator-always-on;
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3300000>;

@@ -80,7 +78,6 @@
 
 			vdd_1v8_reg: VDCDC3 {
 				regulator-name = "vdd_1v8";
-				compatible = "regulator-fixed";
 				regulator-always-on;
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;

@@ -88,7 +85,6 @@
 
 			vdd_usb18_reg: LDO1 {
 				regulator-name = "vdd_usb18";
-				compatible = "regulator-fixed";
 				regulator-always-on;
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;

@@ -96,7 +92,6 @@
 
 			vdd_usb33_reg: LDO2 {
 				regulator-name = "vdd_usb33";
-				compatible = "regulator-fixed";
 				regulator-always-on;
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3300000>;
Signature · 1 line
2.17.0
author
#1 lore raw
Quoted 10 lines · Adam Ford

The AM3517-EVM uses a TPS65023 PMIC. This is already defined
by: compatible = "ti,tps65023"

There doesn't seem to be a need to have each regulator in the PMIC with the 'compatible = "regulator-fixed"' since each regulator has a min and max setting.

Signed-off-by Adam Ford <[email protected]>

Gentle nudge

adam

Quoted 47 lines
arch/arm/boot/dts/am3517-som.dtsi +0 -6
index a6d5ff73c163..7ff7cd135dca 100644
@@ -64,7 +64,6 @@
                regulators {
                        vdd_core_reg: VDCDC1 {
                                regulator-name = "vdd_core";
-                               compatible = "regulator-fixed";
                                regulator-always-on;
                                regulator-min-microvolt = <1200000>;
                                regulator-max-microvolt = <1200000>;

@@ -72,7 +71,6 @@
 
                        vdd_io_reg: VDCDC2 {
                                regulator-name = "vdd_io";
-                               compatible = "regulator-fixed";
                                regulator-always-on;
                                regulator-min-microvolt = <3300000>;
                                regulator-max-microvolt = <3300000>;

@@ -80,7 +78,6 @@
 
                        vdd_1v8_reg: VDCDC3 {
                                regulator-name = "vdd_1v8";
-                               compatible = "regulator-fixed";
                                regulator-always-on;
                                regulator-min-microvolt = <1800000>;
                                regulator-max-microvolt = <1800000>;

@@ -88,7 +85,6 @@
 
                        vdd_usb18_reg: LDO1 {
                                regulator-name = "vdd_usb18";
-                               compatible = "regulator-fixed";
                                regulator-always-on;
                                regulator-min-microvolt = <1800000>;
                                regulator-max-microvolt = <1800000>;

@@ -96,7 +92,6 @@
 
                        vdd_usb33_reg: LDO2 {
                                regulator-name = "vdd_usb33";
-                               compatible = "regulator-fixed";
                                regulator-always-on;
                                regulator-min-microvolt = <3300000>;
                                regulator-max-microvolt = <3300000>;
--

2.17.0

#2 lore raw
Quoted 5 lines · Adam Ford
Quoted 4 lines · Adam Ford

The AM3517-EVM uses a TPS65023 PMIC. This is already defined
by: compatible = "ti,tps65023"

Quoted 8 lines
Quoted 6 lines

There doesn't seem to be a need to have each regulator in the PMIC with the 'compatible = "regulator-fixed"' since each regulator has a min and max setting.

Signed-off-by Adam Ford <[email protected]>

Gentle nudge

Sorry for the delay, applying into omap-for-v4.19/dt thanks.

Regards,

Tony