Skip to contentSkip to conversation

imx_usb_loader: Allow target build

PATCH New Vincent Prince 2 participants 4 messages May 16, 2018 – May 19, 2018 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx_usb_loader: Allow target build

---
 package/Config.in                        |  1 +
 package/imx-usb-loader/Config.in         | 10 ++++++++++
 package/imx-usb-loader/imx-usb-loader.mk |  8 ++++++++
 3 files changed, 19 insertions(+)
 create mode 100644 package/imx-usb-loader/Config.in
package/Config.in +1 -0
index 2be6c64..3cf53ed 100644
@@ -186,6 +186,7 @@ menu "Filesystem and flash utilities"
 	source "package/genext2fs/Config.in"
 	source "package/genpart/Config.in"
 	source "package/genromfs/Config.in"
+	source "package/imx-usb-loader/Config.in"
 	source "package/mfgtools/Config.in"
 	source "package/mmc-utils/Config.in"
 	source "package/mtd/Config.in"
package/imx-usb-loader/Config.in new file +10 -0
new file mode 100644
index 0000000..41585e2
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_IMX_USB_LOADER
+	bool "imx-usb-loader"
+	depends on BR2_arm
+    select BR2_PACKAGE_LIBUSB
+	help
+	  This package contains tools to download and execute code
+	  on Freescale i.MX5/i.MX6 and Vybrid SoCs through the
+	  Serial Download Protocol.
+
+	  https://github.com/boundarydevices/imx_usb_loader
package/imx-usb-loader/imx-usb-loader.mk +8 -0
index 946a1f3..22698dd 100644
@@ -8,14 +8,22 @@ IMX_USB_LOADER_VERSION = 7e77787c83288a421080a9bf2f67063931f561be
 IMX_USB_LOADER_SITE = $(call github,boundarydevices,imx_usb_loader,$(IMX_USB_LOADER_VERSION))
 IMX_USB_LOADER_LICENSE = LGPL-2.1+
 IMX_USB_LOADER_LICENSE_FILES = COPYING
+IMX_USB_LOADER_DEPENDENCIES = libusb 
 HOST_IMX_USB_LOADER_DEPENDENCIES = host-libusb host-pkgconf
 
+define IMX_USB_LOADER_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
 define HOST_IMX_USB_LOADER_BUILD_CMDS
 	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)
 endef
 
+define IMX_USB_LOADER_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) prefix=$(TARGET_DIR) install
+endef
 define HOST_IMX_USB_LOADER_INSTALL_CMDS
 	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) prefix=$(HOST_DIR) install
 endef
 
+$(eval $(generic-package))
 $(eval $(host-generic-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 imx_usb_loader: Allow target build

Hello,

Quoted 1 line · Vincent Prince

Could you give some details on the use case for having a target package for the imx_usb_loader ? Are you building a system with Buildroot that itself is responsible for loading a bootloader over USB to a separate i.MX6 target ? If not, what is your use case ?

package/imx-usb-loader/Config.in line 3

Quoted 9 lines
package/imx-usb-loader/Config.in new file +3 -0
new file mode 100644
index 0000000..41585e2
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_IMX_USB_LOADER
+	bool "imx-usb-loader"
+	depends on BR2_arm

Why do you have this dependency ? If your use case is as explained above to build a Buildroot system that itself will be responsible for loading over USB the bootloader of a separate i.MX6 device, then this system may be running on something else than an ARM platform.

package/imx-usb-loader/Config.in line 4

Quoted 1 line
package/imx-usb-loader/Config.in new file +1 -0
+    select BR2_PACKAGE_LIBUSB

Indentation is wrong for this line, it should be indented with one tab. I can fix this up when applying once the use case is clearer.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 imx_usb_loader: Allow target build

Hi Thomas,

For automatic testing purpose, I use an intermediate target (arm) between host and DUT.
It uses imx_usb_loader and otp_com (https://github.com/ixonos/utp_com) as described here:
https://community.nxp.com/thread/441563 to flash imx6 DUT with labgrid.

Indeed, extra arm depends is a mistake.

Sorry for indentation,

Best regards,
Vincent

2018-05-19 14:29 GMT+02:00 Thomas Petazzoni <[email protected]>:

Quoted 31 lines

Hello,

Quoted 1 line · Vincent Prince

Could you give some details on the use case for having a target package for the imx_usb_loader ? Are you building a system with Buildroot that itself is responsible for loading a bootloader over USB to a separate i.MX6 target ? If not, what is your use case ?

package/imx-usb-loader/

Quoted 1 line
package/imx-usb-loader/ renamed from package/imx-usb-loader/Config.in +0 -0

Config.in

package/imx-usb-loader/Config.in line 3

Quoted 8 lines

new file mode 100644
index 0000000..41585e2

package/imx-usb-loader/Config.in new file +3 -0
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_IMX_USB_LOADER
+     bool "imx-usb-loader"
+     depends on BR2_arm

Why do you have this dependency ? If your use case is as explained above to build a Buildroot system that itself will be responsible for loading over USB the bootloader of a separate i.MX6 device, then this system may be running on something else than an ARM platform.

package/imx-usb-loader/Config.in line 4

Quoted 1 line
package/imx-usb-loader/Config.in new file +1 -0
+    select BR2_PACKAGE_LIBUSB

Indentation is wrong for this line, it should be indented with one tab. I can fix this up when applying once the use case is clearer.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180519/07e33e5a/attachment.html>

#3 lore raw

PATCH 1/1 imx_usb_loader: Allow target build

In reply to Vincent Prince

Hello,

Quoted 7 lines · Vincent Prince
---
 package/Config.in                        |  1 +
 package/imx-usb-loader/Config.in         | 10 ++++++++++
 package/imx-usb-loader/imx-usb-loader.mk |  8 ++++++++
 3 files changed, 19 insertions(+)
 create mode 100644 package/imx-usb-loader/Config.in

I've applied to next, after doing the following changes:

[Thomas:
- improve commit log
- fix indentation
- drop BR2_arm dependency
- add missing host-pkgconf dependency
- fix prefix variable to install in $(TARGET_DIR)/usr]

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com