Skip to contentSkip to conversation

Tests for preemptoff and irqsoff tracers

RFC PATCH Superseded Joel Fernandes 4 participants 7 messages May 18, 2018 – May 21, 2018

Subsystems (3)

v1 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

cover Tests for preemptoff and irqsoff tracers

From: "Joel Fernandes (Google)" <[email protected]>

Hi,
Here is test code and kselftest for testing the preemptoff and irqsoff tracers. I am posting it separately just for early feedback since its the first time I'm writing a kselftest.

I am planning to include these tests in the next series posting of "Centralize and unify usage of preempt/irq tracepoints" [1]

By the way, other than these I have also completed testing with Ingo's locking API test suite for [1]. I will include these and other results in the v7 posting of [1].

[1] http://lkml.iu.edu/hypermail/linux/kernel/1805.0/04948.html

Joel Fernandes (Google) (2):
lib: Add module to simulate atomic sections for testing
{preempt,irqs}off tracers
kselftests: ftrace: Add tests for the preemptoff and irqsoff tracers

 lib/Kconfig.debug                             |  9 +++
 lib/Makefile                                  |  1 +
 lib/test_atomic_sections.c                    | 80 +++++++++++++++++++
 tools/testing/selftests/ftrace/config         |  3 +
 .../test.d/preemptirq/irqsoff_tracer.tc       | 74 +++++++++++++++++
 5 files changed, 167 insertions(+)
 create mode 100644 lib/test_atomic_sections.c
 create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
Cc Steven Rostedt <[email protected]>
Cc Peter Zilstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Mathieu Desnoyers <[email protected]>
Cc Tom Zanussi <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Thomas Glexiner <[email protected]>
Cc Boqun Feng <[email protected]>
Cc Paul McKenney <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Erick Reyes <[email protected]>
Cc Julia Cartwright <[email protected]>
Signature · 1 line
2.17.0.441.gb46fe60e1d-goog
#1 lore raw

PATCH 1/2 lib: Add module to simulate atomic sections for testing {preempt,irqs}off tracers

From: "Joel Fernandes (Google)" <[email protected]>

In this patch we introduce a test module for simulating a long atomic section in the kernel which the preemptoff or irqsoff tracers can detect. This module is to be used only for test purposes and is default disabled.

Following is the expected output (only briefly shown) that can be parsed to verify that the tracers are working correctly. We will use this from the kselftests in future patches.

For the preemptoff tracer:

echo preemptoff > /d/tracing/current_tracer
sleep 1
insmod ./test_atomic_sections.ko atomic_mode=preempt atomic_time=500000 sleep 1
bash-4.3# cat /d/tracing/trace

preempt -1066    2...2    0us@: atomic_sect_run <-atomic_sect_run
preempt -1066    2...2 500002us : atomic_sect_run <-atomic_sect_run
preempt -1066    2...2 500004us : tracer_preempt_on <-atomic_sect_run
preempt -1066    2...2 500012us : <stack trace>

=> kthread
=> ret_from_fork

For the irqsoff tracer:

echo irqsoff > /d/tracing/current_tracer
sleep 1
insmod ./test_atomic_sections.ko atomic_mode=irq atomic_time=500000 sleep 1
bash-4.3# cat /d/tracing/trace

irq dis -1069    1d..1    0us@: atomic_sect_run
irq dis -1069    1d..1 500001us : atomic_sect_run
irq dis -1069    1d..1 500002us : tracer_hardirqs_on <-atomic_sect_run
irq dis -1069    1d..1 500005us : <stack trace>

=> ret_from_fork

Cc Steven Rostedt <[email protected]>
Cc Peter Zilstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Mathieu Desnoyers <[email protected]>
Cc Tom Zanussi <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Thomas Glexiner <[email protected]>
Cc Boqun Feng <[email protected]>
Cc Paul McKenney <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Erick Reyes <[email protected]>
Cc Julia Cartwright <[email protected]>
---
 lib/Kconfig.debug          |  9 +++++
 lib/Makefile               |  1 +
 lib/test_atomic_sections.c | 80 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 90 insertions(+)
 create mode 100644 lib/test_atomic_sections.c
lib/Kconfig.debug +9 -0
index c40c7b734cd1..4bb865a1f430 100644
@@ -1933,6 +1933,15 @@ config TEST_KMOD
 
 	  If unsure, say N.
 
+config TEST_ATOMIC_SECTIONS
+	tristate "Simulate atomic sections for tracers to detect"
+	default n
+	depends on m
+	help
+	  Select this option to build a test module that can help test atomic
+	  sections by simulating them with a duration supplied as a module
+	  parameter. Preempt disable and irq disable modes can be requested.
+
 config TEST_DEBUG_VIRTUAL
 	tristate "Test CONFIG_DEBUG_VIRTUAL feature"
 	depends on DEBUG_VIRTUAL
lib/Makefile +1 -0
index ce20696d5a92..e82cf5445b7b 100644
@@ -46,6 +46,7 @@ obj-y += string_helpers.o
 obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
 obj-y += hexdump.o
 obj-$(CONFIG_TEST_HEXDUMP) += test_hexdump.o
+obj-$(CONFIG_TEST_ATOMIC_SECTIONS) += test_atomic_sections.o
 obj-y += kstrtox.o
 obj-$(CONFIG_FIND_BIT_BENCHMARK) += find_bit_benchmark.o
 obj-$(CONFIG_TEST_BPF) += test_bpf.o
lib/test_atomic_sections.c new file +80 -0

80 lines not on this page · raw message

Signature · 1 line
2.17.0.441.gb46fe60e1d-goog
#2 lore raw

Re: [PATCH 1/2] lib: Add module to simulate atomic sections for testing {preempt,irqs}off tracers

Quoted 11 lines · Joel Fernandes

From: "Joel Fernandes (Google)" <[email protected]>

In this patch we introduce a test module for simulating a long atomic section in the kernel which the preemptoff or irqsoff tracers can detect. This module is to be used only for test purposes and is default disabled.

Following is the expected output (only briefly shown) that can be parsed to verify that the tracers are working correctly. We will use this from the kselftests in future patches.

lib/Kconfig.debug config TEST_KMOD · line 1938

Quoted 4 lines
lib/Kconfig.debug +3 -0
+config TEST_ATOMIC_SECTIONS
+       tristate "Simulate atomic sections for tracers to detect"
 
+       default n

n _is_ default default.

Quoted 1 line

+/*

SPDX?

lib/test_atomic_sections.c line 20

Quoted 11 lines

+ */

lib/test_atomic_sections.c new file +9 -0
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/ktime.h>
+#include <linux/irq.h>
+#include <linux/printk.h>
+#include <linux/interrupt.h>
+#include <linux/delay.h>
+#include <linux/string.h>
+#include <linux/kthread.h>

Perhaps keep in order?

lib/test_atomic_sections.c line 40

Quoted 11 lines
lib/test_atomic_sections.c new file +10 -0
+
+static int atomic_time = 100;
+static char atomic_mode[10] = "irq";
+
+module_param_named(atomic_time, atomic_time, int, S_IRUGO);
+module_param_string(atomic_mode, atomic_mode, 10, S_IRUGO);
+MODULE_PARM_DESC(atomic_time, "Period in microseconds (100 uS default)");
+MODULE_PARM_DESC(atomic_mode, "Mode of the test such as preempt or irq (default irq)");
 
+
+

Extra blank line.

lib/test_atomic_sections.c line 63

Quoted 7 lines
lib/test_atomic_sections.c new file +6 -0
+static int __init atomic_sect_init(void)
+{
+       char task_name[50];
+       struct task_struct *test_task;
+
 
+       sprintf(task_name, "%s dis test", atomic_mode);

Just to be protective from dumb user.

snprintf();

lib/test_atomic_sections.c line 67

Quoted 5 lines
lib/test_atomic_sections.c new file +4 -0
+
+       test_task = kthread_run((void*)atomic_sect_run, NULL, task_name);
+       if (IS_ERR(test_task)) {
 
+               return -1;

return PTR_ERR() ?

Quoted 4 lines
lib/test_atomic_sections.c new file +4 -0
+       }
+
+       return 0;
+}
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

Re: [PATCH 1/2] lib: Add module to simulate atomic sections for testing {preempt,irqs}off tracers

Quoted 12 lines · Andy Shevchenko
Quoted 10 lines · Joel Fernandes

From: "Joel Fernandes (Google)" <[email protected]>

In this patch we introduce a test module for simulating a long atomic section in the kernel which the preemptoff or irqsoff tracers can detect. This module is to be used only for test purposes and is default disabled.

Following is the expected output (only briefly shown) that can be parsed to verify that the tracers are working correctly. We will use this from the kselftests in future patches.

Quoted 6 lines

lib/Kconfig.debug config TEST_KMOD · line 1938

Quoted 4 lines
lib/Kconfig.debug +3 -0
+config TEST_ATOMIC_SECTIONS
+       tristate "Simulate atomic sections for tracers to detect"
 
+       default n

n _is_ default default.

I would rather be explicit, several other TEST configs also mention it. Is it a strong desire to drop off default n?

Quoted 3 lines
Quoted 1 line

+/*

SPDX?

Ok, will add.

Quoted 14 lines

lib/test_atomic_sections.c line 20

Quoted 12 lines

+ */

lib/test_atomic_sections.c new file +9 -0
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/ktime.h>
+#include <linux/irq.h>
+#include <linux/printk.h>
+#include <linux/interrupt.h>
+#include <linux/delay.h>
+#include <linux/string.h>
+#include <linux/kthread.h>

Perhaps keep in order?

Sure.

Quoted 9 lines
Quoted 8 lines
lib/test_atomic_sections.c new file +8 -0
+
+static int atomic_time = 100;
+static char atomic_mode[10] = "irq";
+
+module_param_named(atomic_time, atomic_time, int, S_IRUGO);
+module_param_string(atomic_mode, atomic_mode, 10, S_IRUGO);
+MODULE_PARM_DESC(atomic_time, "Period in microseconds (100 uS default)");
+MODULE_PARM_DESC(atomic_mode, "Mode of the test such as preempt or irq (default irq)");
Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+

Extra blank line.

Fixed

Quoted 6 lines
Quoted 5 lines
lib/test_atomic_sections.c new file +5 -0
+static int __init atomic_sect_init(void)
+{
+       char task_name[50];
+       struct task_struct *test_task;
+
Quoted 6 lines
Quoted 1 line

+ sprintf(task_name, "%s dis test", atomic_mode);

Just to be protective from dumb user.

snprintf();

Done.

Quoted 7 lines

lib/test_atomic_sections.c line 67

Quoted 5 lines
lib/test_atomic_sections.c new file +4 -0
+
+       test_task = kthread_run((void*)atomic_sect_run, NULL, task_name);
+       if (IS_ERR(test_task)) {
 
+               return -1;

return PTR_ERR() ?

Sure, will do. Thanks for the review!

- Joel

#4 lore raw

Re: [PATCH 1/2] lib: Add module to simulate atomic sections for testing {preempt,irqs}off tracers

Quoted 9 lines · Joel Fernandes
Quoted 5 lines · Andy Shevchenko
Quoted 1 line · Joel Fernandes

+ default n

n _is_ default default.

I would rather be explicit, several other TEST configs also mention it. Is it a strong desire to drop off default n?

I guess so, it comes from Linus. See, for example, commit 0192f17529fa clean up x86 platform driver default values

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw

Re: [PATCH 1/2] lib: Add module to simulate atomic sections for testing {preempt,irqs}off tracers

In reply to Joel Fernandes
Thank you for the patch! Perhaps something to improve:

Hi Joel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc6 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Joel-Fernandes/Tests-for-preemptoff-and-irqsoff-tracers/20180521-064835
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64

All warnings (new ones prefixed by >>):

lib/test_atomic_sections.c: In function 'atomic_sect_exit':

>> lib/test_atomic_sections.c:75:9: warning: 'return' with a value, in function returning void
     return 0;
            ^

lib/test_atomic_sections.c:73:20: note: declared here
static void __exit atomic_sect_exit(void)
^~~~~~~~~~~~~~~~

vim +/return +75 lib/test_atomic_sections.c

    72	
    73	static void __exit atomic_sect_exit(void)
    74	{
  > 75		return 0;
    76	}
    77	

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#6 lore raw

PATCH 2/2 kselftests: ftrace: Add tests for the preemptoff and irqsoff tracers

In reply to Joel Fernandes

From: "Joel Fernandes (Google)" <[email protected]>

Here we add unit tests for the preemptoff and irqsoff tracer by using a kernel module introduced previously to trigger atomic sections in the kernel.

Cc Steven Rostedt <[email protected]>
Cc Peter Zilstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Mathieu Desnoyers <[email protected]>
Cc Tom Zanussi <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Thomas Glexiner <[email protected]>
Cc Boqun Feng <[email protected]>
Cc Paul McKenney <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Todd Kjos <[email protected]>
Cc Erick Reyes <[email protected]>
Cc Julia Cartwright <[email protected]>
---
 tools/testing/selftests/ftrace/config         |  3 +
 .../test.d/preemptirq/irqsoff_tracer.tc       | 74 +++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
tools/testing/selftests/ftrace/config +3 -0
index b01924c71c09..29588b328345 100644
@@ -4,3 +4,6 @@ CONFIG_FUNCTION_PROFILER=y
 CONFIG_TRACER_SNAPSHOT=y
 CONFIG_STACK_TRACER=y
 CONFIG_HIST_TRIGGERS=y
+CONFIG_PREEMPT_TRACER=y
+CONFIG_IRQSOFF_TRACER=y
+CONFIG_TEST_ATOMIC_SECTIONS=m
tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc new file +74 -0

74 lines not on this page · raw message

Signature · 1 line
2.17.0.441.gb46fe60e1d-goog