Skip to contentSkip to conversation

Added Dell Wireless 1537 Ath6kl sdio card (0x19) to the list.

PATCH In review Guy Chronister 2 participants 2 messages May 21, 2018 Atheros ATH6KL wireless driver

lore
Share & tools
lore

Guy Chronister

author
#0 lore raw

PATCH 1/1 Added Dell Wireless 1537 Ath6kl sdio card (0x19) to the list.

Signed-off-by Guy Chronister <[email protected]>
---
 drivers/net/wireless/ath/ath6kl/sdio.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath6kl/sdio.c +1 -0
index 2195b1b7a8a6..bb50680580f3 100644
@@ -1415,6 +1415,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
 	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
 	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
 	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
+	{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x19))},
 	{},
 };
Signature · 1 line
2.17.0
#1 lore raw

Hi Guy,

Review

Quoted 6 lines · Guy Chronister
Signed-off-by Guy Chronister <[email protected]>
---
  drivers/net/wireless/ath/ath6kl/sdio.c | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/net/wireless/ath/ath6kl/sdio.c

drivers/net/wireless/ath/ath6kl/sdio.c static const struct sdio_device_id

Quoted 4 lines

index 2195b1b7a8a6..bb50680580f3 100644

drivers/net/wireless/ath/ath6kl/sdio.c +0 -0
@@ -1415,6 +1415,7 @@ static const struct sdio_device_id

ath6kl_sdio_devices[] = {

drivers/net/wireless/ath/ath6kl/sdio.c static const struct sdio_device_id · line 1415

Quoted 1 line
drivers/net/wireless/ath/ath6kl/sdio.c +0 -0
         {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |

0x1))},

drivers/net/wireless/ath/ath6kl/sdio.c static const struct sdio_device_id · line 1416

Quoted 1 line
drivers/net/wireless/ath/ath6kl/sdio.c +0 -0
         {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |

0x2))},

drivers/net/wireless/ath/ath6kl/sdio.c static const struct sdio_device_id · line 1417

Quoted 1 line
drivers/net/wireless/ath/ath6kl/sdio.c +0 -0
         {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |

0x18))},

drivers/net/wireless/ath/ath6kl/sdio.c static const struct sdio_device_id · line 1418

Quoted 1 line
drivers/net/wireless/ath/ath6kl/sdio.c +1 -0
+       {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE |

0x19))},

drivers/net/wireless/ath/ath6kl/sdio.c static const struct sdio_device_id · line 1420

Quoted 2 lines
drivers/net/wireless/ath/ath6kl/sdio.c +0 -0
         {},
  };

Thanks for this. I'd like to see more information in the git commit message. While I get that this is some Dell card, it would be helpful to know what is the actual chip, which firmware, sdio id, and what tests were done to confirm this worked. Honestly I'm a bit surprised to see a new ath6k chip ID.

Thanks,
- Steve