Skip to contentSkip to conversation

kselftest/cgroup: fix variable dereferenced before check warning

PATCH In review Roman Gushchin 2 participants 2 messages May 22, 2018

Subsystems (2)
Kselftest cgroup
lore
Share & tools
lore

Roman Gushchin

author
#0 lore raw

PATCH 1/1 kselftest/cgroup: fix variable dereferenced before check warning

cg_name(const char *root, const char *name) is always called with non-empty root and name arguments, so there is no sense in checking it in the function body (after using in strlen()).

Signed-off-by Roman Gushchin <guro at fb.com>
Reported-by Dan Carpenter <dan.carpenter at oracle.com>
Cc linux-kselftest at vger.kernel.org
---
 tools/testing/selftests/cgroup/cgroup_util.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
tools/testing/selftests/cgroup/cgroup_util.c +2 -4
index 41cc3b5e5be1..b69bdeb4b9fe 100644
@@ -59,8 +59,7 @@ char *cg_name(const char *root, const char *name)
 	size_t len = strlen(root) + strlen(name) + 2;
 	char *ret = malloc(len);
 
-	if (name)
-		snprintf(ret, len, "%s/%s", root, name);
+	snprintf(ret, len, "%s/%s", root, name);
 
 	return ret;
 }

@@ -70,8 +69,7 @@ char *cg_name_indexed(const char *root, const char *name, int index)
 	size_t len = strlen(root) + strlen(name) + 10;
 	char *ret = malloc(len);
 
-	if (name)
-		snprintf(ret, len, "%s/%s_%d", root, name, index);
+	snprintf(ret, len, "%s/%s_%d", root, name, index);
 
 	return ret;
 }
Signature · 6 lines
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#1 lore raw
Quoted 7 lines · Roman Gushchin

cg_name(const char *root, const char *name) is always called with non-empty root and name arguments, so there is no sense in checking it in the function body (after using in strlen()).

Signed-off-by Roman Gushchin <guro at fb.com>
Reported-by Dan Carpenter <dan.carpenter at oracle.com>
Cc linux-kselftest at vger.kernel.org

Thanks. I will queue this up for 4.18-rc1

-- Shuah

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html