x86: acpi: Adopt new version of iASL compiler
PATCH 1/1 x86: acpi: Adopt new version of iASL compiler
The commit
f9a88a4c1cd0 ("iASL: Enhance the -tc option (create AML hex file in C)")
in ACPICA project changed a template of the a of variable that is used in the generated C-file. Now, instead of hard coded "AmlCode" the "%s_aml_code" is in use, where the prefix is a lowered case base name of the output file. In our case it will be "dsdt" producing a name as "dsdt_aml_code".
The quick solution is to call sed which replaces new name by the old one to keep compatibility with old version of iASL.
The long term solution would be to modify code to use the new name because it more scalable.
--- scripts/Makefile.lib | 1 + 1 file changed, 1 insertion(+)
scripts/Makefile.lib +1 -0
@@ -416,6 +416,7 @@ cmd_acpi_c_asl= \ $(obj)/dsdt.c: $(src)/dsdt.asl $(call cmd,acpi_c_asl) + $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@ # Bzip2 # ---------------------------------------------------------------------------
Signature · 1 line
2.17.0
PATCH 1/1 x86: acpi: Adopt new version of iASL compiler
Hi Andy,
Quoted 5 lines · Andy Shevchenko
The commit
f9a88a4c1cd0("iASL: Enhance the -tc option (create AML hex file in C)")in ACPICA project changed a template of the a of variable that is used
a template of the a of variable? Cannot understand this.
Quoted 10 lines
in the generated C-file. Now, instead of hard coded "AmlCode" the "%s_aml_code" is in use, where the prefix is a lowered case base name of the output file. In our case it will be "dsdt" producing a name as "
dsdt_aml_code".The quick solution is to call sed which replaces new name by the old one to keep compatibility with old version of iASL.
The long term solution would be to modify code to use the new name because it more scalable.
it *is* more scalable.
Quoted 14 lines
Cc Robert Moore <[email protected]>Cc Sami Mujawar <[email protected]>Cc Evan Lloyd <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- scripts/Makefile.lib | 1 + 1 file changed, 1 insertion(+)scripts/Makefile.lib +0
-0
scripts/Makefile.lib cmd_acpi_c_asl= \
Quoted 8 lines
scripts/Makefile.lib +1
-1@@ -416,6 +416,7 @@ cmd_acpi_c_asl= \ $(obj)/dsdt.c: $(src)/dsdt.asl $(call cmd,acpi_c_asl) + $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@ # Bzip2 # --------------------------------------------------------------------------- --
Otherwise,
Regards,
Bin
PATCH 1/1 x86: acpi: Adopt new version of iASL compiler
Quoted 6 lines · Bin Meng
Hi Andy,
Quoted 2 lines · Andy Shevchenko
The commit
Quoted 7 lines
Quoted 5 lines
f9a88a4c1cd0("iASL: Enhance the -tc option (create AML hex file
in C)")in ACPICA project changed a template of the a of variable that is used
a template of the a of variable? Cannot understand this.
"a template of the variable"
Quoted 7 lines
Quoted 7 lines
in the generated C-file. Now, instead of hard coded "AmlCode" the "%s_aml_code" is in use, where the prefix is a lowered case base name of
the output file. In our case it will be "dsdt" producing a name as "dsdt_aml_code".
Quoted 8 lines
Quoted 6 lines
The quick solution is to call sed which replaces new name by the old one
to keep compatibility with old version of iASL.The long term solution would be to modify code to use the new name because it more scalable.
it *is* more scalable.
Yes, thanks.
Quoted 30 lines
Quoted 15 lines
Cc Robert Moore <[email protected]>Cc Sami Mujawar <[email protected]>Cc Evan Lloyd <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- scripts/Makefile.lib | 1 + 1 file changed, 1 insertion(+)scripts/Makefile.lib +0
-0scripts/Makefile.lib cmd_acpi_c_asl= \
Quoted 9 lines
scripts/Makefile.lib +1
-2@@ -416,6 +416,7 @@ cmd_acpi_c_asl= \ $(obj)/dsdt.c: $(src)/dsdt.asl $(call cmd,acpi_c_asl) + $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@ # Bzip2 # --------------------------------------------------------------- ------------ --Otherwise,
Reviewed-by Bin Meng <[email protected]>Regards,
Bin
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Moore
PATCH 1/1 x86: acpi: Adopt new version of iASL compiler
Quoted 11 lines
-----Original Message-----
From: Andy Shevchenko [mailto:andriy.shevchenko at linux.intel.com]
Sent: Wednesday, May 23, 2018 3:30 AM
To: Bin Meng <[email protected]>
Cc: Simon Glass <[email protected]>; U-Boot Mailing List <u- boot at lists.denx.de>; Moore, Robert <[email protected]>; Sami Mujawar <[email protected]>; Evan Lloyd <[email protected]>
Subject: Re: [PATCH v1] x86: acpi: Adopt new version of iASL compiler
Quoted 10 lines
Quoted 9 lines · Bin Meng
Hi Andy,
Quoted 5 lines · Andy Shevchenko
The commit
f9a88a4c1cd0("iASL: Enhance the -tc option (create AML hex file
in C)")
[Moore, Robert]
This change was requested by a customer, and it seemed quite reasonable to us. Sorry for any inconvenience.
Bob
Quoted 57 lines
Quoted 4 lines
Quoted 2 lines
in ACPICA project changed a template of the a of variable that is used
a template of the a of variable? Cannot understand this.
"a template of the variable"
Quoted 6 lines
Quoted 6 lines
in the generated C-file. Now, instead of hard coded "AmlCode" the "%s_aml_code" is in use, where the prefix is a lowered case base name of the output file. In our case it will be "dsdt" producing a name as "
dsdt_aml_code".Quoted 7 lines
Quoted 5 lines
The quick solution is to call sed which replaces new name by the old one to keep compatibility with old version of iASL.
The long term solution would be to modify code to use the new name because it more scalable.
it *is* more scalable.
Yes, thanks.
Quoted 26 lines
Quoted 15 lines
Cc Robert Moore <[email protected]>Cc Sami Mujawar <[email protected]>Cc Evan Lloyd <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- scripts/Makefile.lib | 1 + 1 file changed, 1 insertion(+)scripts/Makefile.lib index renamed from scripts/Makefile.lib +0
-0
f9809ce7ce..b5cf7e5427100644scripts/Makefile.lib cmd_acpi_c_asl= \
Quoted 9 lines
scripts/Makefile.lib +1
-2@@ -416,6 +416,7 @@ cmd_acpi_c_asl= \ $(obj)/dsdt.c: $(src)/dsdt.asl $(call cmd,acpi_c_asl) + $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@ # Bzip2 # --------------------------------------------------------------- ------------ --Otherwise,
Quoted 4 lines
Reviewed-by Bin Meng <[email protected]>Regards,
Bin--
Andy Shevchenko <[email protected]> Intel Finland Oy
PATCH 1/1 x86: acpi: Adopt new version of iASL compiler
In reply to Andy ShevchenkoQuoted 10 lines · Andy Shevchenko
Quoted 9 lines · Bin Meng
Hi Andy,
Quoted 5 lines · Andy Shevchenko
The commit
f9a88a4c1cd0("iASL: Enhance the -tc option (create AML hex file
in C)")
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
in ACPICA project changed a template of the a of variable that is used
a template of the a of variable? Cannot understand this.
"a template of the variable"
Fixed this in the commit message
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
in the generated C-file. Now, instead of hard coded "AmlCode" the "%s_aml_code" is in use, where the prefix is a lowered case base name of
the output file. In our case it will be "dsdt" producing a name as "dsdt_aml_code".The quick solution is to call sed which replaces new name by the old one
to keep compatibility with old version of iASL.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
The long term solution would be to modify code to use the new name because it more scalable.
it *is* more scalable.
Yes, thanks.
and here, and
applied to u-boot-x86, thanks!