drm/xen-front: fix pointer casts
Subsystems (3)
PATCH v2 1/1 drm/xen-front: fix pointer casts
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to uintptr_t first.
---
Changes since v1:
- remove unneeded u64 and phys_addr_t casts (Juergen)
drivers/gpu/drm/xen/xen_drm_front.h | 4 ++-- drivers/gpu/drm/xen/xen_drm_front_shbuf.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/xen/xen_drm_front.h +2 -2
@@ -126,12 +126,12 @@ struct xen_drm_front_drm_info {static inline u64 xen_drm_front_fb_to_cookie (struct drm_framebuffer *fb) { -return (u64 )fb; +return (uintptr_t )fb; }static inline u64 xen_drm_front_dbuf_to_cookie (struct drm_gem_object *gem_obj) { -return (u64 )gem_obj; +return (uintptr_t )gem_obj; } int xen_drm_front_mode_set(struct xen_drm_front_drm_pipeline *pipeline,
drivers/gpu/drm/xen/xen_drm_front_shbuf.c +1 -1
@@ -122,7 +122,7 @@ static void guest_calc_num_grefs(struct xen_drm_front_shbuf *buf) }#define xen_page_to_vaddr (page) \ - ((phys_addr_t)pfn_to_kaddr(page_to_xen_pfn(page))) + ((uintptr_t)pfn_to_kaddr(page_to_xen_pfn(page)))static int backend_unmap (struct xen_drm_front_shbuf *buf) {
Signature · 1 line
2.17.0
Quoted 7 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.Signed-off-by Oleksandr Andrushchenko <[email protected]>
Juergen
Oleksandr Andrushchenko
AppliedQuoted 9 lines · Juergen Gross
Quoted 7 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.Signed-off-by Oleksandr Andrushchenko <[email protected]>Reviewed-by Juergen Gross <[email protected]>
Thank you, applied to drm-misc-next
Quoted 2 lines
Juergen
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 8 lines · Oleksandr Andrushchenko
Quoted 7 lines · Juergen Gross
Quoted 6 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Signed-off-by: Oleksandr Andrushchenko
<[email protected]>Reviewed-by Juergen Gross <[email protected]>Thank you, applied to drm-misc-next
Is this the right branch? Shouldn't this go to drm-misc-fixes instead, so it reaches the tree before the 4.18 release?
Just stumbled over the issue when compiling 4.18-rc1 for arm32, so it definitely needs fixing in this cycle.
Cheers,
Andre.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Oleksandr Andrushchenko
maintainerQuoted 11 lines · Andre Przywara
Hi,
Quoted 8 lines · Oleksandr Andrushchenko
Quoted 7 lines · Juergen Gross
Quoted 6 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Signed-off-by: Oleksandr Andrushchenko
<[email protected]>Reviewed-by Juergen Gross <[email protected]>Thank you, applied to drm-misc-next
Is this the right branch? Shouldn't this go to drm-misc-fixes instead, so it reaches the tree before the 4.18 release?
Just stumbled over the issue when compiling 4.18-rc1 for arm32, so it definitely needs fixing in this cycle.
Maarten, can this be done please?
Quoted 2 lines
Cheers,
Andre.
Thank you,
Oleksandr
Oleksandr Andrushchenko
maintainerQuoted 11 lines · Andre Przywara
Hi,
Quoted 8 lines · Oleksandr Andrushchenko
Quoted 7 lines · Juergen Gross
Quoted 6 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
Quoted 2 lines
Signed-off-by: Oleksandr Andrushchenko
<[email protected]>Reviewed-by Juergen Gross <[email protected]>Thank you, applied to drm-misc-next
Is this the right branch? Shouldn't this go to drm-misc-fixes instead, so it reaches the tree before the 4.18 release?
Just stumbled over the issue when compiling 4.18-rc1 for arm32, so it definitely needs fixing in this cycle.
Maarten, can this be done please?
Quoted 2 lines
Cheers,
Andre.
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Hi,
Quoted 8 lines · Oleksandr Andrushchenko
Quoted 7 lines · Juergen Gross
Quoted 6 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Signed-off-by: Oleksandr Andrushchenko
<[email protected]>Reviewed-by Juergen Gross <[email protected]>Thank you, applied to drm-misc-next
Is this the right branch? Shouldn't this go to drm-misc-fixes instead, so it reaches the tree before the 4.18 release?
Just stumbled over the issue when compiling 4.18-rc1 for arm32, so it definitely needs fixing in this cycle.
Cheers,
Andre.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Oleksandr Andrushchenko
AppliedQuoted 9 lines · Juergen Gross
Quoted 7 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.Signed-off-by Oleksandr Andrushchenko <[email protected]>Reviewed-by Juergen Gross <[email protected]>
Thank you, applied to drm-misc-next
Quoted 2 lines
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Building for a 32-bit target results in warnings from casting between a 32-bit pointer and a 64-bit integer. Fix the warnings by casting those pointers to
uintptr_tfirst.Signed-off-by Oleksandr Andrushchenko <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel