Add new packge Shadowsocks-libev v3.1.3
PATCH 1/1 Add new packge Shadowsocks-libev v3.1.3
--- package/Config.in | 1 + package/shadowsocks-libev/Config.in | 12 ++++++++++++ package/shadowsocks-libev/shadowsocks-libev.mk | 20 ++++++++++++++++++++ 3 files changed, 33 insertions(+) create mode 100644 package/shadowsocks-libev/Config.in create mode 100644 package/shadowsocks-libev/shadowsocks-libev.mk
package/Config.in +1 -0
@@ -1846,6 +1846,7 @@ endif source "package/samba4/Config.in" source "package/sconeserver/Config.in" source "package/ser2net/Config.in" + source "package/shadowsocks-libev/Config.in" source "package/shairport-sync/Config.in" source "package/shellinabox/Config.in" source "package/smcroute/Config.in"
package/shadowsocks-libev/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_SHADOWSOCKS_LIBEV + bool "shadowsocks-libev" + select BR2_PACKAGE_LIBSODIUM + select BR2_PACKAGE_MBEDTLS + select BR2_PACKAGE_PCRE + select BR2_PACKAGE_C_ARES + select BR2_PACKAGE_LIBEV + help + Shadowsocks-libev is a lightweight secured SOCKS5 proxy for + embedded devices and low-end boxes. + + https://github.com/shadowsocks/shadowsocks-libev
package/shadowsocks-libev/shadowsocks-libev.mk new file +20 -0
@@ -0,0 +1,20 @@ +################################################################################ +# +# SHADOWSOCKS_LIBEV +# +################################################################################ + +SHADOWSOCKS_LIBEV_VERSION = 3.1.3 +SHADOWSOCKS_LIBEV_SOURCE = shadowsocks-libev-$(SHADOWSOCKS_LIBEV_VERSION).tar.gz +SHADOWSOCKS_LIBEV_SITE = https://github.com/shadowsocks/shadowsocks-libev/releases/download/v$(SHADOWSOCKS_LIBEV_VERSION) +SHADOWSOCKS_LIBEV_LICENSE = GPLv3 +SHADOWSOCKS_LIBEV_DEPENDENCIES = host-pkgconf +SHADOWSOCKS_LIBEV_LICENSE_FILES = COPYING +SHADOWSOCKS_LIBEV_INSTALL_STAGING = YES +SHADOWSOCKS_LIBEV_CONF_ENV = PCRECONFIG=$(STAGING_DIR)/usr/bin/pcre-config +SHADOWSOCKS_LIBEV_DEPENDENCIES += pcre +SHADOWSOCKS_LIBEV_CONF_OPTS = --disable-documentation --with-pcre=$(STAGING_DIR)/usr/bin/ + +$(eval $(autotools-package)) +$(eval $(host-autotools-package)) +
Signature · 1 line
2.11.0
PATCH 1/1 Add new packge Shadowsocks-libev v3.1.3
Hi Min,
Thank you for your contributions. There are several problems with your patch,
could you fix them and resubmit?
First of all, the subject line should be:
shadowsocks-libev: new package
Quoted 5 lines · Min Xu
Signed-off-by Min Xu <[email protected]>--- package/Config.in | 1 + package/shadowsocks-libev/Config.in | 12 ++++++++++++ package/shadowsocks-libev/shadowsocks-libev.mk | 20 ++++++++++++++++++++
Please also add a hash file, containing a hash for the tarball and for all
license files.
package/Config.in endif · line 1849
Quoted 13 lines
3 files changed, 33 insertions(+) create mode 100644 package/shadowsocks-libev/Config.in create mode 100644 package/shadowsocks-libev/shadowsocks-libev.mkpackage/Config.in +1
-0@@ -1846,6 +1846,7 @@ endif source "package/samba4/Config.in" source "package/sconeserver/Config.in" source "package/ser2net/Config.in" + source "package/shadowsocks-libev/Config.in"
Indentation should be with tabs.
Similar problems exist elsewhere as well. Please use the utils/check-package
script to find such mistakes.
Quoted 9 lines
package/Config.in +0
-0source "package/shairport-sync/Config.in" source "package/shellinabox/Config.in" source "package/smcroute/Config.in"package/shadowsocks-libev/Config.in new file +0
-0
package/shadowsocks-libev/Config.in line 7
Quoted 7 lines
package/shadowsocks-libev/Config.in new file +7
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_SHADOWSOCKS_LIBEV + bool "shadowsocks-libev" + select BR2_PACKAGE_LIBSODIUM + select BR2_PACKAGE_MBEDTLS + select BR2_PACKAGE_PCRE + select BR2_PACKAGE_C_ARES + select BR2_PACKAGE_LIBEV
Please keep the select lines alphabetical. So c-ares should be first.
Quoted 11 lines
package/shadowsocks-libev/Config.in new file +5
-0+ help + Shadowsocks-libev is a lightweight secured SOCKS5 proxy for + embedded devices and low-end boxes. + + https://github.com/shadowsocks/shadowsocks-libevpackage/shadowsocks-libev/shadowsocks-libev.mk new file +0
-0
package/shadowsocks-libev/shadowsocks-libev.mk line 3
Quoted 3 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +3
-0@@ -0,0 +1,20 @@ +################################################################################ +# +# SHADOWSOCKS_LIBEV
This should be lower case.
package/shadowsocks-libev/shadowsocks-libev.mk line 8
Quoted 5 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +5
-0+# +################################################################################ + +SHADOWSOCKS_LIBEV_VERSION = 3.1.3 +SHADOWSOCKS_LIBEV_SOURCE = shadowsocks-libev-$(SHADOWSOCKS_LIBEV_VERSION).tar.gz
This is the default so you can omit it.
package/shadowsocks-libev/shadowsocks-libev.mk line 10
Quoted 2 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +2
-0+SHADOWSOCKS_LIBEV_SITE = https://github.com/shadowsocks/shadowsocks-libev/releases/download/v$(SHADOWSOCKS_LIBEV_VERSION) +SHADOWSOCKS_LIBEV_LICENSE = GPLv3
Use SPDX tags, so GPL-3.0.
It looks to me like it has 'or later' everywhere, so GPL-3.0+.
It looks like it includes additional libraries under different licenses. So it
should be (I think, please check)
SHADOWSOCKS_LIBEV_LICENSE = GPL-3.0+, BSD-2-Clause (libbloom), \
BSD-3-Clause (libcork, libipset)
Note that murmur2 is public domain and doesn't need to be mentioned.
Also the LICENSE_FILES should immediately follow it, and include the license
files for all of these:
SHADOWSOCKS_LIBEV_LICENSE_FILES = COPYING libbloom/COPYING libcork/COPYING
(libipset is a bit problematic because it doesn't have a license file in the tarball. The git repo does have it, though, and it's identical to the one lin libcork as far as I can tell.)
Also please add hashes for all these files.
package/shadowsocks-libev/shadowsocks-libev.mk line 11
Quoted 1 line
package/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0+SHADOWSOCKS_LIBEV_DEPENDENCIES = host-pkgconf
You need to specify all build dependencies here, alphabetically. So:
SHADOWSOCKS_LIBEV_DEPENDENCIES = host-pkgconf c-ares libev libsodium mbedtls pcre
package/shadowsocks-libev/shadowsocks-libev.mk line 19
Quoted 8 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +8
-0+SHADOWSOCKS_LIBEV_LICENSE_FILES = COPYING +SHADOWSOCKS_LIBEV_INSTALL_STAGING = YES +SHADOWSOCKS_LIBEV_CONF_ENV = PCRECONFIG=$(STAGING_DIR)/usr/bin/pcre-config +SHADOWSOCKS_LIBEV_DEPENDENCIES += pcre +SHADOWSOCKS_LIBEV_CONF_OPTS = --disable-documentation --with-pcre=$(STAGING_DIR)/usr/bin/ + +$(eval $(autotools-package)) +$(eval $(host-autotools-package))
You should only add a host version of the package if it is needed for something.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 Add new packge Shadowsocks-libev v3.1.3
Hi Arnout,
Thank you so much for your help. This is my first contributions. I think I fixed all the problem. My new submit is here:
https://patchwork.ozlabs.org/patch/921864/
Thanks.
MinXu
Quoted 156 lines · Arnout Vandecappelle
Hi Min,
Thank you for your contributions. There are several problems with your
patch,
could you fix them and resubmit?First of all, the subject line should be:
shadowsocks-libev: new package
Quoted 5 lines · Min Xu
Signed-off-by Min Xu <[email protected]>--- package/Config.in | 1 + package/shadowsocks-libev/Config.in | 12 ++++++++++++ package/shadowsocks-libev/shadowsocks-libev.mk | 20++++++++++++++++++++
Please also add a hash file, containing a hash for the tarball and for all
license files.package/Config.in endif · line 1849
Quoted 13 lines
3 files changed, 33 insertions(+) create mode 100644 package/shadowsocks-libev/Config.in create mode 100644 package/shadowsocks-libev/shadowsocks-libev.mkpackage/Config.in +1
-0@@ -1846,6 +1846,7 @@ endif source "package/samba4/Config.in" source "package/sconeserver/Config.in" source "package/ser2net/Config.in" + source "package/shadowsocks-libev/Config.in"Indentation should be with tabs.
Similar problems exist elsewhere as well. Please use the
utils/check-package
script to find such mistakes.Review
Quoted 4 lines
package/Config.in +0
-0source "package/shairport-sync/Config.in" source "package/shellinabox/Config.in" source "package/smcroute/Config.in"(quoted diff) +0
-0b/package/shadowsocks-libev/Config.in
package/shadowsocks-libev/Config.in line 7
Quoted 12 lines
new file mode 100644
index 0000000..78fd35apackage/shadowsocks-libev/Config.in new file +7
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_SHADOWSOCKS_LIBEV + bool "shadowsocks-libev" + select BR2_PACKAGE_LIBSODIUM + select BR2_PACKAGE_MBEDTLS + select BR2_PACKAGE_PCRE + select BR2_PACKAGE_C_ARES + select BR2_PACKAGE_LIBEVPlease keep the select lines alphabetical. So c-ares should be first.
Review
Quoted 6 lines
package/shadowsocks-libev/Config.in new file +5
-0+ help + Shadowsocks-libev is a lightweight secured SOCKS5 proxy for + embedded devices and low-end boxes. + + https://github.com/shadowsocks/shadowsocks-libev(quoted diff) +0
-0
b/package/shadowsocks-libev/shadowsocks-libev.mkpackage/shadowsocks-libev/shadowsocks-libev.mk line 1
Quoted 6 lines
new file mode 100644
index 0000000..1c7f76apackage/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0@@ -0,0 +1,20 @@ +################################################################################
package/shadowsocks-libev/shadowsocks-libev.mk line 3
Quoted 2 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +2
-0+# +# SHADOWSOCKS_LIBEVThis should be lower case.
package/shadowsocks-libev/shadowsocks-libev.mk line 5
Quoted 2 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +2
-0+# +################################################################################
package/shadowsocks-libev/shadowsocks-libev.mk
Quoted 3 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +3
-0+ +SHADOWSOCKS_LIBEV_VERSION = 3.1.3 +SHADOWSOCKS_LIBEV_SOURCE = shadowsocks-libev-$(SHADOWSOCKS_LIBEV_VERSION).tar.gz
This is the default so you can omit it.
package/shadowsocks-libev/shadowsocks-libev.mk line 9
Quoted 1 line
package/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0+SHADOWSOCKS_LIBEV_SITE = https://github.com/shadowsocks/shadowsocks-libev/releases/download/v$(
SHADOWSOCKS_LIBEV_VERSION)package/shadowsocks-libev/shadowsocks-libev.mk line 10
Quoted 1 line
package/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0+SHADOWSOCKS_LIBEV_LICENSE = GPLv3Use SPDX tags, so GPL-3.0.
It looks to me like it has 'or later' everywhere, so GPL-3.0+.
It looks like it includes additional libraries under different licenses.
So it
should be (I think, please check)
SHADOWSOCKS_LIBEV_LICENSE= GPL-3.0+, BSD-2-Clause (libbloom), \
BSD-3-Clause (libcork, libipset)Note that murmur2 is public domain and doesn't need to be mentioned.
Also the
LICENSE_FILESshould immediately follow it, and include the
license
files for all of these:
SHADOWSOCKS_LIBEV_LICENSE_FILES= COPYING libbloom/COPYING libcork/COPYING(libipset is a bit problematic because it doesn't have a license file in the
tarball. The git repo does have it, though, and it's identical to the one lin
libcork as far as I can tell.)Also please add hashes for all these files.
package/shadowsocks-libev/shadowsocks-libev.mk line 11
Quoted 1 line
package/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0+SHADOWSOCKS_LIBEV_DEPENDENCIES = host-pkgconfYou need to specify all build dependencies here, alphabetically. So:
SHADOWSOCKS_LIBEV_DEPENDENCIES= host-pkgconf c-ares libev libsodium mbedtls pcrepackage/shadowsocks-libev/shadowsocks-libev.mk
Quoted 3 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +3
-0+SHADOWSOCKS_LIBEV_LICENSE_FILES = COPYING +SHADOWSOCKS_LIBEV_INSTALL_STAGING = YES +SHADOWSOCKS_LIBEV_CONF_ENV = PCRECONFIG=$(STAGING_DIR)/usr/bin/pcre-config
package/shadowsocks-libev/shadowsocks-libev.mk line 16
Quoted 2 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +2
-0+SHADOWSOCKS_LIBEV_DEPENDENCIES += pcre +SHADOWSOCKS_LIBEV_CONF_OPTS = --disable-documentation--with-pcre=$(STAGING_DIR)/usr/bin/
package/shadowsocks-libev/shadowsocks-libev.mk line 19
Quoted 3 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +3
-0+ +$(eval $(autotools-package)) +$(eval $(host-autotools-package))You should only add a host version of the package if it is needed for
something.Regards,
Arnout--
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Signature · 6 lines
*Best Regards* *XuMin's Ready?* -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180529/7fc7a49c/attachment.html>
PATCH 1/1 Add new packge Shadowsocks-libev v3.1.3
Hi Arnout,
I just notice my last submit still miss libbloom/COPYING libcork/COPYING, ipset/COPYING. Please discard my last submit. I'll resubmit a new one tomorrow. Sorry about that.
MinXu
Quoted 178 lines · xu min
Hi Arnout,
Thank you so much for your help. This is my first contributions. I think I fixed all the problem. My new submit is here: https://patchwork.
ozlabs.org/patch/921864/
Thanks.MinXu
Quoted 149 lines · Arnout Vandecappelle
Hi Min,
Thank you for your contributions. There are several problems with your
patch,
could you fix them and resubmit?First of all, the subject line should be:
shadowsocks-libev: new package
Quoted 5 lines · Min Xu
Signed-off-by Min Xu <[email protected]>--- package/Config.in | 1 + package/shadowsocks-libev/Config.in | 12 ++++++++++++ package/shadowsocks-libev/shadowsocks-libev.mk | 20++++++++++++++++++++
Please also add a hash file, containing a hash for the tarball and for
all
license files.package/Config.in endif · line 1849
Quoted 13 lines
3 files changed, 33 insertions(+) create mode 100644 package/shadowsocks-libev/Config.in create mode 100644 package/shadowsocks-libev/shadowsocks-libev.mkpackage/Config.in +1
-0@@ -1846,6 +1846,7 @@ endif source "package/samba4/Config.in" source "package/sconeserver/Config.in" source "package/ser2net/Config.in" + source "package/shadowsocks-libev/Config.in"Indentation should be with tabs.
Similar problems exist elsewhere as well. Please use the
utils/check-package
script to find such mistakes.Review
Quoted 4 lines
package/Config.in +0
-0source "package/shairport-sync/Config.in" source "package/shellinabox/Config.in" source "package/smcroute/Config.in"(quoted diff) +0
-0b/package/shadowsocks-libev/Config.in
package/shadowsocks-libev/Config.in line 7
Quoted 12 lines
new file mode 100644
index 0000000..78fd35apackage/shadowsocks-libev/Config.in new file +7
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_SHADOWSOCKS_LIBEV + bool "shadowsocks-libev" + select BR2_PACKAGE_LIBSODIUM + select BR2_PACKAGE_MBEDTLS + select BR2_PACKAGE_PCRE + select BR2_PACKAGE_C_ARES + select BR2_PACKAGE_LIBEVPlease keep the select lines alphabetical. So c-ares should be first.
Review
Quoted 6 lines
package/shadowsocks-libev/Config.in new file +5
-0+ help + Shadowsocks-libev is a lightweight secured SOCKS5 proxy for + embedded devices and low-end boxes. + + https://github.com/shadowsocks/shadowsocks-libev(quoted diff) +0
-0
b/package/shadowsocks-libev/shadowsocks-libev.mkpackage/shadowsocks-libev/shadowsocks-libev.mk line 1
Quoted 6 lines
new file mode 100644
index 0000000..1c7f76apackage/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0@@ -0,0 +1,20 @@ +################################################################################
package/shadowsocks-libev/shadowsocks-libev.mk line 3
Quoted 2 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +2
-0+# +# SHADOWSOCKS_LIBEVThis should be lower case.
package/shadowsocks-libev/shadowsocks-libev.mk line 5
Quoted 2 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +2
-0+# +################################################################################
package/shadowsocks-libev/shadowsocks-libev.mk
Quoted 3 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +3
-0+ +SHADOWSOCKS_LIBEV_VERSION = 3.1.3 +SHADOWSOCKS_LIBEV_SOURCE = shadowsocks-libev-$(SHADOWSOCKS_LIBEV_VERSION).tar.gz
This is the default so you can omit it.
package/shadowsocks-libev/shadowsocks-libev.mk line 9
Quoted 1 line
package/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0+SHADOWSOCKS_LIBEV_SITE = https://github.com/shadowsocks/shadowsocks-libev/releases/download/v$(SHADOWSOCKS_LIBEV_VERSION)
package/shadowsocks-libev/shadowsocks-libev.mk line 10
Quoted 1 line
package/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0+SHADOWSOCKS_LIBEV_LICENSE = GPLv3Use SPDX tags, so GPL-3.0.
It looks to me like it has 'or later' everywhere, so GPL-3.0+.
It looks like it includes additional libraries under different licenses.
So it
should be (I think, please check)
SHADOWSOCKS_LIBEV_LICENSE= GPL-3.0+, BSD-2-Clause (libbloom), \
BSD-3-Clause (libcork, libipset)Note that murmur2 is public domain and doesn't need to be mentioned.
Also the
LICENSE_FILESshould immediately follow it, and include the
license
files for all of these:
SHADOWSOCKS_LIBEV_LICENSE_FILES= COPYING libbloom/COPYING libcork/COPYING(libipset is a bit problematic because it doesn't have a license file in the
tarball. The git repo does have it, though, and it's identical to the one lin
libcork as far as I can tell.)Also please add hashes for all these files.
package/shadowsocks-libev/shadowsocks-libev.mk line 11
Quoted 1 line
package/shadowsocks-libev/shadowsocks-libev.mk new file +1
-0+SHADOWSOCKS_LIBEV_DEPENDENCIES = host-pkgconfYou need to specify all build dependencies here, alphabetically. So:
SHADOWSOCKS_LIBEV_DEPENDENCIES= host-pkgconf c-ares libev libsodium mbedtls pcrepackage/shadowsocks-libev/shadowsocks-libev.mk
Quoted 3 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +3
-0+SHADOWSOCKS_LIBEV_LICENSE_FILES = COPYING +SHADOWSOCKS_LIBEV_INSTALL_STAGING = YES +SHADOWSOCKS_LIBEV_CONF_ENV = PCRECONFIG=$(STAGING_DIR)/usr/bin/pcre-config
package/shadowsocks-libev/shadowsocks-libev.mk line 16
Quoted 2 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +2
-0+SHADOWSOCKS_LIBEV_DEPENDENCIES += pcre +SHADOWSOCKS_LIBEV_CONF_OPTS = --disable-documentation--with-pcre=$(STAGING_DIR)/usr/bin/
package/shadowsocks-libev/shadowsocks-libev.mk line 19
Quoted 3 lines
package/shadowsocks-libev/shadowsocks-libev.mk new file +3
-0+ +$(eval $(autotools-package)) +$(eval $(host-autotools-package))You should only add a host version of the package if it is needed for
something.Regards,
ArnoutQuoted 8 lines
--
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF--
*Best Regards*
*XuMin's Ready?*
Signature · 6 lines
*Best Regards* *XuMin's Ready?* -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180530/d0690684/attachment.html>