Skip to contentSkip to conversation

ARM: pxa3xx: enable external wakeup pins

PATCH New Daniel Mack 2 participants 4 messages May 24, 2018 – May 25, 2018

Subsystems (3)
Arm (32-bit) Arm sub-architectures PXA2xx/PXA3xx support
lore
Share & tools
lore

Daniel Mack

author maintainer
#0 lore raw

PATCH 1/1 ARM: pxa3xx: enable external wakeup pins

The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins have no alternate functions, so let's always enable them as wakeup source on DT enabled boards. The WAKEUP1 pin is only available on PXA320.

Signed-off-by Daniel Mack <[email protected]>
---
 arch/arm/mach-pxa/pxa3xx.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-pxa/pxa3xx.c +4 -0
index 2a5044dd463e..9e05f92cd97a 100644
@@ -442,6 +442,10 @@ static int __init pxa3xx_init(void)
 
 		pxa3xx_init_pm();
 
+		enable_irq_wake(IRQ_WAKEUP0);
+		if (cpu_is_pxa320())
+			enable_irq_wake(IRQ_WAKEUP1);
+
 		register_syscore_ops(&pxa_irq_syscore_ops);
 		register_syscore_ops(&pxa3xx_mfp_syscore_ops);
Signature · 1 line
2.14.3
maintainer
#1 lore raw

PATCH 1/1 ARM: pxa3xx: enable external wakeup pins

Quoted 5 lines · Daniel Mack

The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins have no alternate functions, so let's always enable them as wakeup source on DT enabled boards. The WAKEUP1 pin is only available on PXA320.

Signed-off-by Daniel Mack <[email protected]>

That looks correct. Is it tested on any board ?

Cheers.

--
Robert

author maintainer
#2 lore raw

PATCH 1/1 ARM: pxa3xx: enable external wakeup pins

Quoted 8 lines · Robert Jarzmik
Quoted 5 lines · Daniel Mack

The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins have no alternate functions, so let's always enable them as wakeup source on DT enabled boards. The WAKEUP1 pin is only available on PXA320.

Signed-off-by Daniel Mack <[email protected]>

That looks correct. Is it tested on any board ?

Yup, on a PXA303 based one.

Thanks,
Daniel

maintainer Applied
#3 lore raw

PATCH 1/1 ARM: pxa3xx: enable external wakeup pins

Quoted 11 lines · Daniel Mack
Quoted 8 lines · Robert Jarzmik
Quoted 5 lines · Daniel Mack

The PXA3xx SoCs feature dedicated pins for wakeup functionality. These pins have no alternate functions, so let's always enable them as wakeup source on DT enabled boards. The WAKEUP1 pin is only available on PXA320.

Signed-off-by Daniel Mack <[email protected]>

That looks correct. Is it tested on any board ?

Yup, on a PXA303 based one.

Great.

Queued into pxa/for-next.

Cheers.

Signature · 1 line
Robert