Skip to contentSkip to conversation

U-Boot thumb interlink patches

U-Boot Tom Rini 4 participants 5 messages May 25, 2018 – May 26, 2018

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

Hey guys,

So, I want to be sure that I get all of the patches that we need in order to fix the thumb interlink problems on older ARM cores applied.

I believe that we have:
https://patchwork.ozlabs.org/patch/905299/

Which could still apply, but I'm wondering if the kernel needs this as well then (in arch/arm/lib/copy_template.S) ?

And then:
https://patchwork.ozlabs.org/patch/909652/

has been reviewed and could be applied. Is there anything else I'm missing? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180525/1750528b/attachment.sig>
#1 lore raw
Quoted 5 lines · Tom Rini

And then:
https://patchwork.ozlabs.org/patch/909652/

has been reviewed and could be applied. Is there anything else I'm missing? Thanks!

I'd be more comfortable with this one if someone actually tested it. I can't since I don't have such hardware.

Signature · 1 line
Måns Rullgård
author
#2 lore raw
Quoted 10 lines · Måns Rullgård
Quoted 5 lines · Tom Rini

And then:
https://patchwork.ozlabs.org/patch/909652/

has been reviewed and could be applied. Is there anything else I'm missing? Thanks!

I'd be more comfortable with this one if someone actually tested it. I can't since I don't have such hardware.

True, Chris, do you have a board you can test this on as well? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180525/e06f552e/attachment.sig>
#3 lore raw

Hi Tom,

Quoted 6 lines · Tom Rini
Quoted 5 lines · Måns Rullgård
Quoted 3 lines · Tom Rini

And then:
https://patchwork.ozlabs.org/patch/909652/

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

has been reviewed and could be applied. Is there anything else I'm missing? Thanks!

I'd be more comfortable with this one if someone actually tested it. I can't since I don't have such hardware.

True, Chris, do you have a board you can test this on as well? Thanks!

I do actually have an old fossil (Marvell Eval board) sitting in the corner of my office that I believe is orion. I haven't powered it up in years, I doubt it's supported in current master (if it ever was). I can see what state it's in if I can trivially get something going I will but I won't have much time to spend on it.

I can say I tested an equivalent change as part of the kirkwood work I've been doing recently without any problems.

#4 lore raw
In reply to Tom Rini

Hi Tom,

Quoted 9 lines · Tom Rini

Hey guys,

So, I want to be sure that I get all of the patches that we need in order to fix the thumb interlink problems on older ARM cores applied.

I believe that we have:
https://patchwork.ozlabs.org/patch/905299/

Applied on todays master and tested with a Thumb build of a mxs U-Boot.

Quoted 2 lines

Which could still apply, but I'm wondering if the kernel needs this as well then (in arch/arm/lib/copy_template.S) ?

Can’t say by just looking at it. And since I did this patches while working on a ARM926EJS I can’t test it on that board as Linux requires ARMv7(M) to build a Thumb2 only kernel. Will try it once I’m in front of a suitable board again. Thanks for the hint.

Quoted 8 lines

And then:
https://patchwork.ozlabs.org/patch/909652/

has been reviewed and could be applied. Is there anything else I'm missing? Thanks!

--
Tom

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180525/e0c92ed1/attachment.sig>