poppler: fix sparc compilation error
PATCH 1/1 poppler: fix sparc compilation error
Fixes:
http://autobuild.buildroot.net/results/64a96663a48ab644bc03c9a3ec2d6a644119dee6
http://autobuild.buildroot.net/results/82e85e12478fc1972b70ad728ed7c1554920c9e3
--- package/poppler/poppler.mk | 3 +++ 1 file changed, 3 insertions(+)
package/poppler/poppler.mk +3 -0
@@ -94,6 +94,9 @@ POPPLER_CONF_OPTS += --enable-poppler-qt5 ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y) POPPLER_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" endif +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) +POPPLER_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -latomic" +endif else POPPLER_CONF_OPTS += --disable-poppler-qt5 endif
Signature · 1 line
2.1.4
PATCH 1/1 poppler: fix sparc compilation error
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Waldemar" == Waldemar Brodkorb <[email protected]> writes:
Fixes:
http://autobuild.buildroot.net/results/64a96663a48ab644bc03c9a3ec2d6a644119dee6
http://autobuild.buildroot.net/results/82e85e12478fc1972b70ad728ed7c1554920c9e3
A bit more detailed commit description would be nice. Why is this only happening on Sparc? Who uses atomic operations, Qt5?
Is it related to the snippet we have in qt5base.mk:
ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC)$(BR2_PACKAGE_QT5_VERSION_LATEST),yy) # Qt 5.8 needs atomics, which on various architectures are in -latomic define QT5BASE_CONFIGURE_ARCH_CONFIG
printf 'LIBS += -latomic\n' >$(QT5BASE_ARCH_CONFIG_FILE)
endef
endif
And E.G. is only needed for QT5_VERSION_LATEST?
Quoted 10 lines
Signed-off-by Waldemar Brodkorb <[email protected]>--- package/poppler/poppler.mk | 3 +++ 1 file changed, 3 insertions(+)package/poppler/poppler.mk +0
-0
package/poppler/poppler.mk POPPLER_CONF_OPTS += --enable-poppler-qt5 · line 99
Quoted 6 lines
package/poppler/poppler.mk +3
-0@@ -94,6 +94,9 @@ POPPLER_CONF_OPTS += --enable-poppler-qt5 ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y) POPPLER_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" endif +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) +POPPLER_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -latomic" +endif
Doesn't that override the -std=c++11 just above? Why is this passed in CXXFLAGS and not E.G. LIBS?
Signature · 1 line
Bye, Peter Korsgaard