patman: add option for limiting the Cc list
PATCH v2 1/1 patman: add option for limiting the Cc list
Many mailing-lists consider a long Cc list a sign of spam and will either drop the message or mark it for moderation. Because patman automatically invokes get_maintainer.pl the Cc list can expand unexpectedly. Allow the user to specify a limit for the Cc list.
This limit is applied after removing any known bouncing addresses. By default no limit is applied.
---
I've fallen foul of the u-boot ML Cc limit a few times recently. I'm not sure what the actual limit is so I've left patman's default behaviour unlimited.
Changes in v2:
- make default None to allow limit 0 to suppress the list completely
tools/patman/patman.py | 4 +++- tools/patman/series.py | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-)
tools/patman/patman.py +3 -1
@@ -38,6 +38,8 @@ parser.add_option('-i', '--ignore-errors', action='store_true', parser.add_option('-m', '--no-maintainers', action='store_false', dest='add_maintainers', default=True, help="Don't cc the file maintainers automatically") +parser.add_option('-l', '--limit-cc', dest='limit', type='int', + default=None, help='Limit the cc list to LIMIT entries [default: %default]') parser.add_option('-n', '--dry-run', action='store_true', dest='dry_run', default=False, help="Do a dry run (create but don't email patches)") parser.add_option('-p', '--project', default=project.DetectProject(),
@@ -157,7 +159,7 @@ else: cc_file = series.MakeCcFile(options.process_tags, cover_fname, not options.ignore_bad_tags, - options.add_maintainers) + options.add_maintainers, options.limit) # Email the patches out (giving the user time to check / cancel) cmd = ''
tools/patman/series.py +4 -1
@@ -202,7 +202,7 @@ class Series(dict): print(col.Color(col.RED, str)) def MakeCcFile(self, process_tags, cover_fname, raise_on_error, - add_maintainers): + add_maintainers, limit): """Make a cc file for us to use for per-commit Cc automation Also stores in self._generated_cc to make ShowActions() faster.
@@ -215,6 +215,7 @@ class Series(dict): add_maintainers: Either: True/False to call the get_maintainers to CC maintainers List of maintainers to include (for testing) + limit: Limit the length of the Cc list Return: Filename of temp file created """
@@ -238,6 +239,8 @@ class Series(dict): print(col.Color(col.YELLOW, 'Skipping "%s"' % x)) cc = set(cc) - set(settings.bounces) cc = [m.encode('utf-8') if type(m) != str else m for m in cc] + if limit is not None: + cc = cc[:limit] all_ccs += cc print(commit.patch, ', '.join(set(cc)), file=fd) self._generated_cc[commit.patch] = cc
Signature · 1 line
2.17.0
PATCH v2 1/1 patman: add option for limiting the Cc list
Quoted 14 lines · Chris Packham
Many mailing-lists consider a long Cc list a sign of spam and will either drop the message or mark it for moderation. Because patman automatically invokes get_maintainer.pl the Cc list can expand unexpectedly. Allow the user to specify a limit for the Cc list.
This limit is applied after removing any known bouncing addresses. By default no limit is applied.
Signed-off-by Chris Packham <[email protected]>---
I've fallen foul of the u-boot ML Cc limit a few times recently. I'm not sure what the actual limit is so I've left patman's default behaviour unlimited.
Quoted 6 lines
Changes in v2:
- make default None to allow limit 0 to suppress the list completelytools/patman/patman.py | 4 +++- tools/patman/series.py | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-)
PATCH v2 1/1 patman: add option for limiting the Cc list
Hi Chris,
Quoted 15 lines · Simon Glass
Quoted 14 lines · Chris Packham
Many mailing-lists consider a long Cc list a sign of spam and will either drop the message or mark it for moderation. Because patman automatically invokes get_maintainer.pl the Cc list can expand unexpectedly. Allow the user to specify a limit for the Cc list.
This limit is applied after removing any known bouncing addresses. By default no limit is applied.
Signed-off-by Chris Packham <[email protected]>---
I've fallen foul of the u-boot ML Cc limit a few times recently. I'm not sure what the actual limit is so I've left patman's default behaviour unlimited.
Quoted 8 lines
Quoted 6 lines
Changes in v2:
- make default None to allow limit 0 to suppress the list completelytools/patman/patman.py | 4 +++- tools/patman/series.py | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-)Reviewed-by Simon Glass <[email protected]>
Unfortunately this breaks the patman tests (patman -t). Can you please take a look?
Regards,
Simon
PATCH v2 1/1 patman: add option for limiting the Cc list
Quoted 26 lines · Simon Glass
Hi Chris,
Quoted 22 lines · Simon Glass
Quoted 20 lines · Chris Packham
Many mailing-lists consider a long Cc list a sign of spam and will either drop the message or mark it for moderation. Because patman automatically invokes get_maintainer.pl the Cc list can expand unexpectedly. Allow the user to specify a limit for the Cc list.
This limit is applied after removing any known bouncing addresses. By default no limit is applied.
Signed-off-by Chris Packham <[email protected]>---
I've fallen foul of the u-boot ML Cc limit a few times recently. I'm not sure what the actual limit is so I've left patman's default behaviour unlimited.Changes in v2:
- make default None to allow limit 0 to suppress the list completelytools/patman/patman.py | 4 +++- tools/patman/series.py | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 1 line
Reviewed-by Simon Glass <[email protected]>Unfortunately this breaks the patman tests (patman -t). Can you please take a look?
Regards,
Simon
Ok, I'll take a look.